Skip to content

Fixes #10964 TextInput maxLength cuts Unicode characters (Emojis) #22463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzxiaosheng wants to merge 1 commit into from
Closed

Fixes #10964 TextInput maxLength cuts Unicode characters (Emojis) #22463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Libraries/Text/TextInput/RCTBaseTextInputView.m
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -295,11 +295,20 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin
}

if (_maxLength) {
NSUInteger allowedLength = _maxLength.integerValue - backedTextInputView.attributedText.string.length + range.length;
__block NSUInteger allowedLength = _maxLength.integerValue - backedTextInputView.attributedText.string.length + range.length;

if (text.length > allowedLength) {
// If we typed/pasted more than one character, limit the text inputted.
if (text.length > 1) {
// Fix TextInput maxlength cuts Unicode caracters (Emojis) #10964
[text enumerateSubstringsInRange:NSMakeRange(0, text.length) options:NSStringEnumerationByComposedCharacterSequences usingBlock:^(NSString * _Nullable substring, NSRange substringRange, NSRange enclosingRange, BOOL * _Nonnull stop){
// ensure emoji character was not cut
if(substringRange.location + substring.length > allowedLength){

@zhongwuzwzhongwuzwMar 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzxiaosheng Hey, please rebase the branch first, sorry for that, it's our fault.
And I think we need treat any emoji as 1 glyph, so here may wrong, because we still use substring's length to compare with allowedLength.

*stop = true;
allowedLength = substringRange.location;
}
}];

// Truncate the input string so the result is exactly maxLength
NSString *limitedString = [text substringToIndex:allowedLength];
NSMutableAttributedString *newAttributedText = [backedTextInputView.attributedText mutableCopy];
Expand Down