Uh oh!
There was an error while loading. Please reload this page.
Conversation
facebook-github-bot
commented
Aug 11, 2015
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
DannyvanderJagt
commented
Aug 13, 2015
@potsypantsy Did you already sign the cla? |
ghost
commented
Aug 13, 2015
@DannyvanderJagt I will sign the cla. But the the bigger problem is actually the tests failing. I am unable to get the tests to pass :( |
DannyvanderJagt
commented
Aug 13, 2015
|
facebook-github-bot
commented
Aug 13, 2015
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
DannyvanderJagt
commented
Aug 13, 2015
I have created a branch with the same changes as this PR and all the tests are passing. Maybe a rebase will help. Besides the rebase the only thing that is different is that I removed this from But that shouldn't be a problem. |
ghost
commented
Aug 14, 2015
@DannyvanderJagt I rebased hopefully tests will pass |
ghost
commented
Aug 14, 2015
@DannyvanderJagt tests still fail :( maybe you should make the pr instead. I will just close this one. |
fixes PushNotificationIOS requestPermissions base on @DannyvanderJagt's fix in #1979