DialogModule supports only FragmentActivity by dulmandakh · Pull Request #23365 · react/react-native

dulmandakh · 2019-02-11T02:58:28Z

Summary

Now RN has only ReactActivity which extends AppCompatActivity, subclass of FragmentActivity, therefore no need to check if activity is FragmentActivity or not. This PR changes DialogModule to work only with FragmentActivity.

Also DialogFragment from Android is deprecated in API 28, and recommends to use DialogFragment from Support Library. Excerpt from DialogFragment documentation.

This class was deprecated in API level 28.
Use the Support Library DialogFragment for consistent behavior across all devices and access to Lifecycle.

BREAKING CHANGE: Brown field apps must extend FragmentActivity or its subclasses.

Changelog

[Android] [Changed] - DialogModule supports only FragmentActivity

Test Plan

CI is green, and works as usual.

dulmandakh · 2019-02-11T04:12:49Z

@mdvacca could you please look at test failure?

hey99xx · 2019-02-11T04:18:46Z

Assuming DialogModule would only be used by new RN apps is a wrong assumption. Casting getCurrentActivity() to ReactActivity would mean that any existing activity that is not a subclass of ReactActivity in brownfield apps would no longer able to use a RN dialog.

dulmandakh · 2019-02-11T04:23:43Z

@hey99xx changed to use AppCompatActivity, but DialogModuleTest is failing. I have very little experience with Java tests. Could you please help with this?

hey99xx · 2019-02-11T04:29:54Z

I still think this PR is an issue. In my company we have a CompanyReactActivity which displays ReactRootViews in fragments. CompanyReactActivity extends from CompanyActivity that has a bunch of company specific onCreate, onDestroy etc. code, and that extends from FragmentActivity. We have never needed to use AppCompatActivity to host RN, and I don't see why the switch is even necessary.

dulmandakh · 2019-02-11T04:33:47Z

@hey99xx I think that it's safe to drop plain Activity support

hey99xx · 2019-02-11T04:34:55Z

While you could obviously cast to FragmentActivity and resolve my worry, another brownfield app may be using a plain Activity and this would still be an issue for them.

I think the intention behind allowing multiple fragment types was beneficial to integrating RN with brownfield apps, I don't know why you'd want to drop that now.

dulmandakh · 2019-02-11T04:39:03Z

@hey99xx Google recommends to extend AppCompatActivity for Android apps, and thought that it's better to drop support for plain Activity. Thanks for you suggestions, I don't have experience with brownfield apps. Now, it uses FragmentActivity.

dulmandakh · 2019-02-11T04:40:37Z

@hey99xx I'll be requesting your review when I make such changes. Thank you

hey99xx · 2019-02-11T05:05:22Z

Btw I think some of RN widgets are not ready to extend from AppCompat classes in couple line changes, they cause runtime issues on old Android versions. I've described what goes wrong in #22885 and made a comment in one of your other PRs.

dulmandakh · 2019-02-11T05:12:20Z

@hey99xx I saw the issue, and though that it would be best to have only FragmentActivity and it's subclasses supported, then remove plain Activity support. Therefore, change how contexts works. Otherwise, we'll have duplicate code to support both FragmentActivity and plain Activity which doubles error surface. Please correct me if wrong.

dulmandakh · 2019-02-11T05:41:59Z

Also found that DialogFragment is deprecated in API 28, and recommends to use DialogFragment from Support Library, which this PR does.

facebook-github-bot

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mdvacca · 2019-02-11T21:55:43Z

The land failed because there is a test that is using activity and can not be casted to FragmentActivity:

java.lang.ClassCastException: android.app.Activity cannot be cast to android.support.v4.app.FragmentActivity
at com.facebook.react.modules.dialog.DialogModule.getFragmentManagerHelper(DialogModule.java:244)
at com.facebook.react.modules.dialog.DialogModule.onHostResume(DialogModule.java:176)
at com.facebook.react.bridge.ReactContext$1.run(ReactContext.java:159)

mdvacca · 2019-02-11T21:57:07Z

This will be a breaking change, should we deprecate? communicate about this change and then change this code?

what do you think @cpojer , @hramos ?

cpojer · 2019-02-11T22:00:54Z

@mdvacca how many people do you think this will be breaking for? If the answer is at most ~8%, then I'd say let's ship this change now and ask them to upgrade.

cpojer · 2019-02-12T10:54:33Z

@mdvacca if it works at FB, let's land it and move forward. We need to do this eventually anyway.

cpojer · 2019-03-18T17:31:19Z

@dulmandakh can you rebase this?

cpojer · 2019-03-19T08:31:16Z

@dulmandakh seems like this is failing android CI. Can you fix?

cpojer · 2019-04-08T22:59:55Z

Let's see if this works.

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpojer · 2019-04-26T08:12:59Z

@dulmandakh we are getting Summary: No build file at third-party/android/support/v7/appcompat-orig/BUCK when resolving target //third-party/android/support/v7/appcompat-orig:appcompat., so it seems we don't have that target.

dulmandakh · 2019-04-26T08:17:34Z

yep, it's AndroidX now. I'll rebase and fix the issue. Almost forgot this PR 😄

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2019-04-26T09:50:05Z

This pull request was successfully merged by @dulmandakh in 243070a.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: This sync includes the following changes: - **[dd4950c](react/react@dd4950c90 )**: [Flight] Implement useId hook ([#24172](react/react#24172)) //<Josh Story>// - **[26a5b3c](react/react@26a5b3c7f )**: Explicitly set `highWaterMark` to 0 for `ReadableStream` ([#24641](react/react#24641)) //<Josh Larson>// - **[aec5759](react/react@aec575914 )**: [Fizz] Send errors down to client ([#24551](react/react#24551)) //<Josh Story>// - **[a276638](react/react@a2766387e )**: [Fizz] Improve text separator byte efficiency ([#24630](react/react#24630)) //<Josh Story>// - **[f786053](react/react@f7860538a )**: Fix typo in useSyncExternalStore main entry point error ([#24631](react/react#24631)) //<François Chalifour>// - **[1bed207](react/react@1bed20731 )**: Add a module map option to the Webpack Flight Client ([#24629](react/react#24629)) //<Sebastian Markbåge>// - **[b2763d3](react/react@b2763d3ea )**: Move hydration code out of normal Suspense path ([#24532](react/react#24532)) //<Andrew Clark>// - **[357a613](react/react@357a61324 )**: [DevTools][Transition Tracing] Added support for Suspense Boundaries ([#23365](react/react#23365)) //<Luna Ruan>// - **[2c8a145](react/react@2c8a1452b )**: Fix ignored setState in Safari when iframe is touched ([#24459](react/react#24459)) //<dan>// - **[6266263](react/react@62662633d )**: Remove enableFlipOffscreenUnhideOrder ([#24545](react/react#24545)) //<Ricky>// - **[34da5aa](react/react@34da5aa69 )**: Only treat updates to lazy as a new mount in legacy mode ([#24530](react/react#24530)) //<Ricky>// - **[46a6d77](react/react@46a6d77e3 )**: Unify JSResourceReference Interfaces ([#24507](react/react#24507)) //<Timothy Yung>// - **[6cbf0f7](react/react@6cbf0f7fa )**: Fork ReactSymbols ([#24484](react/react#24484)) //<Ricky>// - **[a10a9a6](react/react@a10a9a6b5 )**: Add test for hiding children after layout destroy ([#24483](react/react#24483)) //<Ricky>// - **[b4eb0ad](react/react@b4eb0ad71 )**: Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored ([#24480](react/react#24480)) //<Josh Story>// - **[99eef9e](react/react@99eef9e2d )**: Hide children of Offscreen after destroy effects ([#24446](react/react#24446)) //<Ricky>// - **[ce13860](react/react@ce1386028 )**: Remove enablePersistentOffscreenHostContainer flag ([#24460](react/react#24460)) //<Andrew Clark>// - **[72b7462](react/react@72b7462fe )**: Bump local package.json versions for 18.1 release ([#24447](react/react#24447)) //<Andrew Clark>// - **[22edb9f](react/react@22edb9f77 )**: React `version` field should match package.json ([#24445](react/react#24445)) //<Andrew Clark>// - **[6bf3dee](react/react@6bf3deef5 )**: Upgrade react-shallow-renderer to support react 18 ([#24442](react/react#24442)) //<Michael サイトー中村 Bashurov>// Changelog: [General][Changed] - React Native sync for revisions bd4784c...d300ceb jest_e2e[run_all_tests] Reviewed By: cortinico, kacieb Differential Revision: D36874368 fbshipit-source-id: c0ee015f4ef2fa56e57f7a1f6bc37dd05c949877

dulmandakh added 2 commits February 11, 2019 10:54

cleanup Dialog module
3898028

cleanup DialogModule
aa54e66

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Partner labels Feb 11, 2019

add ReactActivity to BUCK
99ce23d

react-native-bot added the PR: Includes Changelog label Feb 11, 2019

dulmandakh added 3 commits February 11, 2019 11:11

add appcompat to BUCK
d443cf6

add modules/core to BUCK
19f5d87

fix DialogModuleTest
062b605

DialogModule use AppCompatActivity
8262c66

use FragmentActivity in DialogModule
431ff06

dulmandakh requested a review from mdvacca February 11, 2019 04:52

dulmandakh changed the title ~~cleanup DialogModule~~DialogModule supports only FragmentActivityFeb 11, 2019

gengjiawen approved these changes Feb 11, 2019
View reviewed changes

facebook-github-bot reviewed Feb 11, 2019
View reviewed changes

dulmandakh added 2 commits February 13, 2019 12:11

merge master
b9f6930

fix typo
ee8040a

hramos added the PR: Blocked on FB label Feb 25, 2019

react-native-bot added Platform: Android Android applications. PR: Includes Changelog labels Mar 14, 2019

hramos removed the PR: Includes Changelog label Mar 14, 2019

dulmandakh added 2 commits March 18, 2019 18:54

merge master
a202b19

resolve confict
57c07fe

dulmandakh added 2 commits March 19, 2019 09:02

import FragmentManager
d367daa

fix DialogModuleTest
deb326c

facebook-github-bot approved these changes Apr 8, 2019
View reviewed changes

hramos removed Partner labels Apr 24, 2019

merge master
4a1b60a

facebook-github-bot approved these changes Apr 26, 2019
View reviewed changes

facebook-github-bot closed this in 243070aApr 26, 2019

react-native-bot added Merged This PR has been merged. and removed Blocked on FB labels Apr 26, 2019

marc-hughes mentioned this pull request Oct 11, 2019
When running on Android, error: Mini App cannot be cast to androidx.fragment.app.FragmentActivity electrode-io/electrode-native#1363
Open

woshi82 mentioned this pull request Oct 12, 2019
MainActivity cannot be cast to androidx.fragment.app.FragmentActivity #26827
Closed

dulmandakh deleted the dialog-cleanup branch October 15, 2019 05:14

Uh oh!

Conversation

dulmandakh commented Feb 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

hey99xx commented Feb 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

hey99xx commented Feb 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

hey99xx commented Feb 11, 2019

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

hey99xx commented Feb 11, 2019

Uh oh!

dulmandakh commented Feb 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulmandakh commented Feb 11, 2019

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

mdvacca commented Feb 11, 2019

Uh oh!

mdvacca commented Feb 11, 2019

Uh oh!

cpojer commented Feb 11, 2019

Uh oh!

cpojer commented Feb 12, 2019

Uh oh!

cpojer commented Mar 18, 2019

Uh oh!

cpojer commented Mar 19, 2019

Uh oh!

cpojer commented Apr 8, 2019

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

cpojer commented Apr 26, 2019

Uh oh!

dulmandakh commented Apr 26, 2019

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

react-native-bot commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dulmandakh commented Feb 11, 2019•
edited
Loading

hey99xx commented Feb 11, 2019•
edited
Loading

hey99xx commented Feb 11, 2019•
edited
Loading

dulmandakh commented Feb 11, 2019•
edited
Loading