Skip to content

Fix #23755 ("RCTImagePickerManager requires main queue setup" warning) - #24314

Closed
scarlac wants to merge 1 commit into
react:masterfrom
scarlac:fix-issue-23755
Closed

Fix #23755 ("RCTImagePickerManager requires main queue setup" warning)#24314
scarlac wants to merge 1 commit into
react:masterfrom
scarlac:fix-issue-23755

Conversation

@scarlac

Copy link
Copy Markdown
Contributor

Summary

Fix#23755 - Which is to remove the warning:

Module RCTImagePickerManager requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Changelog

General Fixed - Warning "RCTImagePickerManager requires main queue setup

Test Plan

Initialize a new react native project and use CameraRoll. Run it. Confirm that warning no longer shows.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2019
@pull-bot

Copy link
Copy Markdown
Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 839358e

@cpojercpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-botfacebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Seph Soliman in 6508b88.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Apr 4, 2019
grabbou pushed a commit that referenced this pull request Apr 17, 2019
#24314)
Summary:
Fix#23755 - Which is to remove the warning:
```
Module RCTImagePickerManager requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.
```
General Fixed - Warning "RCTImagePickerManager requires main queue setup
Pull Request resolved: #24314
Differential Revision: D14788772
Pulled By: cpojer
fbshipit-source-id: e2017136008367d36468debb258afa698b5402bc
@scarlac
scarlac deleted the fix-issue-23755 branch January 6, 2021 17:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Component: ImageMergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@scarlac@pull-bot@react-native-bot@cpojer@facebook-github-bot