Uh oh!
There was an error while loading. Please reload this page.
[standards] Rewrite imports in RNTester to use standard paths - #24317
[standards] Rewrite imports in RNTester to use standard paths#24317ide wants to merge 2 commits into
Conversation
dd3aae8 to
e70413dCompare
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
flowfound some issues.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e70413d to
7244c35Comparecpojer
commented
Apr 7, 2019
Instead of the relative paths, what do you think about doing |
7244c35 to
7d90a08Compare
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
Uh oh!
There was an error while loading. Please reload this page.
7d90a08 to
52c99b8Compareide
commented
Apr 10, 2019
|
See react#24316 for the motivation. This commit rewrites the imports in the RNTester project. Test Plan: Run RNTester and verify that it loads without any issues. Tap through each screen to ensure the JS modules load (that is, were bundled) correctly.
Instead of requiring specific files and bypassing the public interface, require react-native's exports where possible instead.
52c99b8 to
d6917e4Compare
cpojer
left a comment
There was a problem hiding this comment.
Nice work. Thank you for doing this.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
Apr 10, 2019
This pull request was successfully merged by @ide in 26cce3d. When will my fix make it into a release? | Upcoming Releases |
Summary: See react#24316 for the motivation. This commit rewrites the imports in the RNTester project. [General] [Changed] - Replaced Haste-style imports with standard path-style imports for RNTester Pull Request resolved: react#24317 Differential Revision: D14870504 Pulled By: cpojer fbshipit-source-id: b14f22e7ce559efc332ced032617ca581196d90f
Summary: This sync includes the following changes: - **[8dcedba](react/react@8dcedba15 )**: Add fallback shim for AbortController ([#24285](react/react#24285)) //<Ricky>// - **[b86baa1](react/react@b86baa1cb )**: Add back lost cache test ([#24317](react/react#24317)) //<Ricky>// - **[bafe912](react/react@bafe912a5 )**: update types for InputContinuousLane and DefaultLane ([#24316](react/react#24316)) //<Leo>// - **[4ebaeae](react/react@4ebaeae40 )**: moved mutation code to passive ([#24251](react/react#24251)) //<Luna Ruan>// - **[caa60e8](react/react@caa60e8fc )**: update types for NonIdleLanes and IdleLane ([#24313](react/react#24313)) //<Leo>// - **[1f7a901](react/react@1f7a901d7 )**: Fix false positive lint error with large number of branches ([#24287](react/react#24287)) //<Stephen Cyron>// - **[f56dfe9](react/react@f56dfe950 )**: Warn on setState() in useInsertionEffect() ([#24298](react/react#24298)) //<dan>// - **[d68b09d](react/react@d68b09def )**: Fix warning about setState in useEffect ([#24295](react/react#24295)) //<dan>// - **[0579154](react/react@057915477 )**: Update create-subscription README ([#24294](react/react#24294)) //<dan>// Changelog: [General][Changed] - React Native sync for revisions e8f4a66...8dcedba jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35581147 fbshipit-source-id: 33661d77eb000fdedab7e506a458fc739eab0056
Summary: This sync includes the following changes: - **[8dcedba](react/react@8dcedba15 )**: Add fallback shim for AbortController ([react#24285](react/react#24285)) //<Ricky>// - **[b86baa1](react/react@b86baa1cb )**: Add back lost cache test ([react#24317](react/react#24317)) //<Ricky>// - **[bafe912](react/react@bafe912a5 )**: update types for InputContinuousLane and DefaultLane ([react#24316](react/react#24316)) //<Leo>// - **[4ebaeae](react/react@4ebaeae40 )**: moved mutation code to passive ([react#24251](react/react#24251)) //<Luna Ruan>// - **[caa60e8](react/react@caa60e8fc )**: update types for NonIdleLanes and IdleLane ([react#24313](react/react#24313)) //<Leo>// - **[1f7a901](react/react@1f7a901d7 )**: Fix false positive lint error with large number of branches ([react#24287](react/react#24287)) //<Stephen Cyron>// - **[f56dfe9](react/react@f56dfe950 )**: Warn on setState() in useInsertionEffect() ([react#24298](react/react#24298)) //<dan>// - **[d68b09d](react/react@d68b09def )**: Fix warning about setState in useEffect ([react#24295](react/react#24295)) //<dan>// - **[0579154](react/react@057915477 )**: Update create-subscription README ([react#24294](react/react#24294)) //<dan>// Changelog: [General][Changed] - React Native sync for revisions e8f4a66...8dcedba jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35581147 fbshipit-source-id: 33661d77eb000fdedab7e506a458fc739eab0056
Summary
See #24316 for the motivation. This commit rewrites the imports in the RNTester project.
Changelog
[General] [Changed] - Replaced Haste-style imports with standard path-style imports for RNTester
Test Plan
Run RNTester and verify that it loads without any issues. Tap through each screen to ensure the JS modules load (that is, were bundled) correctly.