[General] [Removed] - remove accessibilityComponentType and accessibilityTraits props (a11y)

[estevaolucas]

Summary

Closes: #24016

React Native 0.57 introduced cross-platform accessibilityRole and accessibilityStates props in order to replace accessibilityComponentType (for android) and accessibilityTraits (for iOS). With #24095accessibilityRole and accessibilityStates will increase, receiving more options, which seems to be a good moment to remove deprecated props.

Changelog

Remove deprecated accessibilityComponentType and accessibilityTraits props.

[General] [Removed] - Remove accessibilityComponentType and accessibilityTraits props

Test Plan

Create a view with old props:

<View
accessible={true} accessibilityComponentType="button"
accessibilityTraits="button">...
</View>

Neither VoiceOver nor TalkBack should announce this element as "button".

Documentation update PR: react/react-native-website#873

Further work: Remove props from Fabric in a separate PR

cc @marcmulcahy@jessebeach

[cpojer]

Let me see what happens when I import this to FB. It may take some work to migrate internally before we can land this.

[facebook-github-bot]

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Did all the necessary work at FB, so just waiting until the diff lands (currently some internal build failure unrelated to this). Thanks for sending a PR removing code, those count triple in my book! :)

[estevaolucas]

@cpojer nice. I'm going to remove those props also in Fabric code. In case the internal failure gets fixed before I remove it, do you mind to hold off the merge? My plan is to do it between today and tomorrow.

[cpojer]

Do you mind doing that in a separate PR? :)

[estevaolucas]

@cpojer sure. I can do it in a separate PR 👍

[react-native-bot]

This pull request was successfully merged by @elucaswork in f70e58f.

^{When will my fix make it into a release? | Upcoming Releases}