Skip to content

feat: Do not require pod install after react-native init#24638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grabbou wants to merge 7 commits into from
Closed

feat: Do not require pod install after react-native init#24638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f7134a
Automatically generate Pod files for template
grabbou Apr 28, 2019
fa10a49
Uncomment more
grabbou Apr 28, 2019
4d5cf81
Do that also while publishing
grabbou Apr 28, 2019
c121363
Update scripts to work while releasing too
grabbou Apr 28, 2019
a440d0c
Explicitly set RN version in bump & test scripts
grabbou Apr 28, 2019
8b0289f
Uneccessary change
grabbou Apr 28, 2019
83d0ba7
Update path to a package.json
grabbou Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions scripts/prepare-template.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
#!/bin/bash
# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

PACKAGE_LOCATION=$(pwd)/react-native-$1.tgz

# Pack React Native into a `.tgz` file so we can run from source
npm pack

# Set the React Native version to point to the `.tgz` file
node scripts/set-rn-template-version.js "file:$PACKAGE_LOCATION"

# We need to generate CocoaPods project. To do so, we install depdendencies

@hramoshramosMay 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# We need to generate CocoaPods project. To do so, we install depdendencies
# We need to generate CocoaPods project. To do so, we install dependencies

# locally and manually run `pod install`
cd template

npm install
Comment thread
grabbou marked this conversation as resolved.
(cd ios && pod install)

@thymikeethymikeeApr 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to pass --repo-update flag so we publish up-to-date pods

@grabbougrabbouApr 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... mind elaborating a bit what that flag is doing? We have local pods (from local spec within the repo, so no need to update the whole CocoaPods repo) and we also rm -rf Pods anyway.

@thymikeethymikeeApr 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot it's local, you're right


# Dependencies are installed on the client-side
rm -rf node_modules

# Do not ship a package.json that points to a `tgz`
git checkout package.json
3 changes: 3 additions & 0 deletions scripts/publish-npm.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -129,6 +129,9 @@ artifacts.forEach(name => {
}
});

// Generate template for this version
exec(`scripts/prepare-template.sh ${releaseVersion}`);

// if version contains -rc, tag as prerelease
const tagFlag = releaseVersion.indexOf('-rc') === -1 ? '' : '--tag next';

Expand Down
10 changes: 3 additions & 7 deletions scripts/test-manual-e2e.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,13 +71,9 @@ success "Killing packager"
lsof -i :8081 | grep LISTEN
lsof -i :8081 | grep LISTEN | /usr/bin/awk '{print $2}' | xargs kill

npm pack

PACKAGE=$(pwd)/react-native-$PACKAGE_VERSION.tgz
success "Package bundled ($PACKAGE)"

node scripts/set-rn-template-version.js "file:$PACKAGE"
success "React Native version changed in the template"
./scripts/prepare-template.sh $PACKAGE_VERSION
node scripts/set-rn-template-version.js "file:$(pwd)/react-native-${PACKAGE_VERSION}.tgz"
success "Sucessfully prepared a template"

project_name="RNTestProject"

Expand Down
Loading