Uh oh!
There was an error while loading. Please reload this page.
Fix event ordering when combining coalescable and non-coalescable events - #24693
Closed
janicduplessis wants to merge 1 commit into
Closed
Fix event ordering when combining coalescable and non-coalescable events#24693janicduplessis wants to merge 1 commit into
janicduplessis wants to merge 1 commit into
Conversation
janicduplessis
commented
May 2, 2019
ContributorAuthor
shergin
commented
May 9, 2019
Contributor
AFAIK, this is hard to repro issue which happens only in prod at scale (one of our top crashes thought!). Looks good and reasonable to me! Thank you so much Janic! ❤️ So, let's land and see what happened. 🤞 |
facebook-github-bot
approved these changes
May 9, 2019
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
May 9, 2019
Collaborator
This pull request was successfully merged by @janicduplessis in 4e215b2. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue introduced in #15894 that can cause events to be dispatched out of order.
Also reverted
viewTagmoved to optional property as it didn't actually work and makes code more complex.Changelog
[iOS] [Fixed] - Fix event ordering when combining coalescable and non-coalescable events
Test Plan
Tested events still work, need to validate it fixes the crash seen @fb