Skip to content

[TM] Fixes wrong headers import - #25002

Closed
zhongwuzw wants to merge 1 commit into
react:masterfrom
zhongwuzw:fix_TM_header
Closed

[TM] Fixes wrong headers import#25002
zhongwuzw wants to merge 1 commit into
react:masterfrom
zhongwuzw:fix_TM_header

Conversation

@zhongwuzw

@zhongwuzwzhongwuzw commented May 23, 2019

Copy link
Copy Markdown
Contributor

Summary

Issue imported from e1102b4 for Android TM support.
Fixes wrong headers import in iOS.

Changelog

[iOS] [Fixed] - [TM] Fixes wrong headers import

Test Plan

TM on iOS run successfully.
image

@zhongwuzw
zhongwuzw requested review from RSNara and cpojerMay 23, 2019 09:25
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2019

@ericlewisericlewis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpojercpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-botfacebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @zhongwuzw in 141a304.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label May 24, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Issue imported from react@e1102b4 for Android TM support.
Fixes wrong headers import in iOS.
## Changelog
[iOS] [Fixed] - [TM] Fixes wrong headers import
Pull Request resolved: react#25002
Differential Revision: D15501594
Pulled By: cpojer
fbshipit-source-id: 45ea2986963ff4937c473464f0befc1f5bcfe115
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Platform: iOSiOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@zhongwuzw@react-native-bot@cpojer@ericlewis@facebook-github-bot