[Android][TextInput] Update types for autoComplete prop.

[drtangible]

Summary

I believe there's a mismatch between the type definitions and the expected prop in Android for TextInput's autoComplete prop.

• Android is expecting autoComplete.
• JS types are expecting autoCompleteType.
• Latest documentation documents autoCompleteType.

Prop added here: 179d490

This change updates the JS types to match what Android is expecting (autoComplete). Can update documentation if this is the approach we'd prefer (rather than updating Android to expect autoCompleteType).

Changelog

[Javascript] [Fixed] - Update types for TextInput's autoComplete prop.

Test Plan

Before:

• Pass invalid value to TextInput's autoComplete prop, see no type errors on JS side, and Android blows up with:

Invalid autocomplete option: foobar
updateViewProp
ViewManagersPropertyCache.java:95
setProperty
ViewManagerPropertyUpdater.java:132
updateProps
ViewManagerPropertyUpdater.java:51
updateProperties
ViewManager.java:37

After:

• Pass invalid value to TextInput's autoComplete prop, see PropType warning for autoComplete prop.

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[rickhanlonii]

Hey @drtangible, thanks for submitting your first RN PR!

This is a great find! This change would be a breaking change for the TextInput component API which we should avoid if possible. There are two ways to do that:

• Update android to change the prop as you mentioned
• Change the prop as it's passed to native

The first option is ideal, but the second is a quick fix. To do the second option you can change TextInput here to be something like:

consttextContainer=(<AndroidTextInput{...props}autoComplete={props.autoCompleteType}// .../>);

This will keep the prop we use in JS as autoCompleteType but send autoComplete to Android.

You can choose either route 👍

[drtangible]

@rickhanlonii Sounds good! Pushed a change on the Android side, but can try to take a look this weekend about anything else that's required for native-side changes.

[mdvacca]

Changes look good to me!
Thanks for working on this @drtangible

[facebook-github-bot]

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @drtangible in daa6b0a.

^{When will my fix make it into a release? | Upcoming Releases}

[rickhanlonii]

@yungsters did you mean to re-open this?

[yungsters]

Whoah, what. No.