Enable module annotation processor with gradle

[janicduplessis]

Summary

Run the module annotation processor with gradle.

To do this we need to separate the annotation and the annotations compiler into separate modules. I kept the same package names but files are now in different folders.

Changelog

[Android] [Added] - Enable module annotation processor with gradle

Test Plan

Run RN tester

[janicduplessis]

BUCK is kind of broken in OSS currently so I wasn't able to get it building 100%. Hermes is missing a BUCK file and the yoga target is missing a dep. Fixing this is outside of the scope of this PR.

This will definitely require a good amount of internal work to update BUCK files for annotations and model. Here are the steps to update the files:

react_native_target("java/com/facebook/react/module/annotations:annotations"), ->
react_native_annotations_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/module/model:model"), ->
react_native_annotations_target("java/com/facebook/react/module/model:model"),
Add "react_native_annotations_target" to the load section

Also I'm not sure how to get the processor to run with BUCK. We probably want to add that code to OSS and adjust the path to the processor.

[janicduplessis]

cc @axe-fb@mdvacca@cpojer

[mdvacca]

Thanks @janicduplessis

[facebook-github-bot]

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[mdvacca]

@janicduplessis This PR is failing internally because react_native_annotations_target does not exists.

@dulmandakh would you like to help to review the Gradle integration?

[janicduplessis]

@mdvacca it is defined here https://github.com/janicduplessis/react-native/blob/edeac0bb77b7ebc2779cb6fa624abc0cf2a62cc4/tools/build_defs/oss/rn_defs.bzl#L80 but this file is used only for oss so you’ll have to add the definition in the one used internally.

[janicduplessis]

@mdvacca Any change you could have a look at this again?

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 1b3581e
Branch: main

[janicduplessis]

Ok so I kept BUCK files in the old location that just re-export the ones in the android/annotations folder, this way no changes should be needed in files that import these modules.

cc @mdvacca@RSNara

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,188,503	-603
android	hermes	armeabi-v7a	7,788,936	-597
android	hermes	x86	8,558,597	-601
android	hermes	x86_64	8,510,974	-605
android	jsc	arm64-v8a	9,858,037	+431
android	jsc	armeabi-v7a	8,843,353	+441
android	jsc	x86	9,824,728	+437
android	jsc	x86_64	10,421,207	+446

Base commit: 1b3581e
Branch: main

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[yungsters]

I have been trying to import this but it's too old (which is totally our fault, to which I apologize).

@janicduplessis, do you still want to push this through? And if so, would you mind helping rebase it?

[janicduplessis]

Hey @yungsters, thanks for looking at this. I have an updated version of it that I've been maintaining in my fork, will update this in a bit.

[analysis-bot]

Code analysis results:

• google-java-format found some issues. See https://github.com/google/google-java-format

[janicduplessis]

@cortinico Done!

[janicduplessis]

@cortinico Is there still interest in merging this? I think it might need some major refactoring with the repo changes that are coming. Maybe you also have some ideas about how we could improve the approach.

[cortinico]

@cortinico Is there still interest in merging this? I think it might need some major refactoring with the repo changes that are coming. Maybe you also have some ideas about how we could improve the approach.

Yes I'd love to have this merged. I've been thinking at this as we approached the RNGP and the monorepo work (which is close to land).

This will have to be moved to a packages/module-spec-annotation-processor (or any other name) and from there we'll have to have a Gradle build that publishes 2 artifacts on Maven Central (the annotation and the process).

[janicduplessis]

Sounds good, I will wait for monorepo work to land first and then try that when I get some time.

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[cortinico]

Hey @janicduplessis
Small heads up that I still have this PR on my plate.

After the monorepo work, we could look into merging it.
The reason why it's currently on hold is that we're looking into understanding what would be the role of Annotation Processors within the New Architecture of React Native.

I should be able to get back to this in 1/2 months. Thanks for your patience.

[cortinico]

Hey @janicduplessis
Sorry for the late reply.

We discussed this internally with @mdvacca and we decided that we'll be dropping the Annotation Processors in the coming future (we'll remove the code generation part from our internal codebase). So I'm closing this now.
We'll reopen this if we revisit this decision