Uh oh!
There was an error while loading. Please reload this page.
[Android] Add support to TextInput for Image Keyboards - #26088
Conversation
facebook-github-bot
commented
Aug 16, 2019
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Aug 16, 2019
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
jasonivers
commented
Jan 9, 2020
Is there any update on the status of this? It might not seem very important, but it IS a nice user enhancement, and the pull request is already here (although it appears it needs updated now). I'd really like to use this, without relying on patching things locally. |
Adds the `onImageInput` prop to TextInput
05775bc to
9e8f29bCompare9e8f29b to
b15ad2cComparestwiname
commented
Jan 9, 2020
@jasonivers, I've rebased so everything is up to date I don't know what can be done to get someone to merge this |
roshangm1
commented
Jan 15, 2020
stwiname
commented
Jan 22, 2020
@roshangm1 are you after example usage or how to run the react-native fork? <TextInputonImageInput={(event)=>{// Will log an object of type { uri: string, linkUri: string, data: string, mime: string}console.log(event.nativeEvent);}}/>Then using an image keyboard on android (Gboard, Fleksy, Tenor gif keyboard and probably a whole lot more) the function will get called. On iOS the |
jasonivers
commented
Jan 22, 2020
There appear to be a couple of test failures. That could be why? |
stwiname
commented
Jan 22, 2020
Those tests seem to be failing on other PRs and unrelated to the changes |
jasonivers
commented
Jan 22, 2020
@JoshuaGross - I saw you merged a pull request for something to do with TextInput, and I have no idea how else to find the right person for this PR. Is there anything that needs done to get the right person's attention? |
Bump. This would be an awesome feature. Also, unless I'm missing something, this PR doesn't seem to introduce this as optional? On some inputs you don't want this capability |
If anyone bumps into this while this PR isn't merged, I've created a package to not only handle this but also images copied to the clipboard on iOS. |
analysis-bot
commented
Apr 19, 2020
Base commit: b000664 |
Base commit: b000664 |
tsvetann
commented
Mar 10, 2021
a year and a half later...any luck here? |
KrisLau
commented
Jul 19, 2021
Would love to have this merged in as well |
TheMakerOleguch
commented
Jul 27, 2022
Any update on this? |
Summary: This sync includes the following changes: - **[86c8c8d](react/react@86c8c8db7 )**: test: Don't retry flushActWork if flushUntilNextPaint threw ([#26121](react/react#26121)) //<Sebastian Silbermann>// - **[64acd39](react/react@64acd3918 )**: remove unguarded getRootNode call ([#26152](react/react#26152)) //<Josh Story>// - **[71cace4](react/react@71cace4d3 )**: Migrate testRunner from jasmine2 to jest-circus ([#26144](react/react#26144)) //<Ming Ye>// - **[c851022](react/react@c8510227c )**: Treat displayName as undefined ([#26148](react/react#26148)) //<Sebastian Markbåge>// - **[55542bc](react/react@55542bc73 )**: Update jest printBasicPrototype config ([#26142](react/react#26142)) //<Ming Ye>// - **[6396b66](react/react@6396b6641 )**: Model Float on Hoistables semantics ([#26106](react/react#26106)) //<Josh Story>// - **[ef9f6e7](react/react@ef9f6e77b )**: Enable passing Server References from Server to Client ([#26124](react/react#26124)) //<Sebastian Markbåge>// - **[3569831](react/react@35698311d )**: Update jest escapeString config ([#26140](react/react#26140)) //<Ming Ye>// - **[6ddcbd4](react/react@6ddcbd4f9 )**: [flow] enable LTI inference mode ([#26104](react/react#26104)) //<Jan Kassens>// - **[53b1f69](react/react@53b1f69ba )**: Implement unstable_getBoundingClientRect in RN Fabric refs ([#26137](react/react#26137)) //<Rubén Norte>// - **[5940934](react/react@594093496 )**: Update to Jest 29 ([#26088](react/react#26088)) //<Ming Ye>// - **[28fcae0](react/react@28fcae062 )**: Add support for SVG `transformOrigin` prop ([#26130](react/react#26130)) //<Aravind D>// - **[3ff1540](react/react@3ff1540e9 )**: Prefer JSX in ReactNoop assertions (to combat out-of-memory test runs) ([#26127](react/react#26127)) //<Sebastian Silbermann>// - **[01a0c4e](react/react@01a0c4e12 )**: Add Edge Server Builds for workerd / edge-light ([#26116](react/react#26116)) //<Sebastian Markbåge>// - **[f0cf832](react/react@f0cf832e1 )**: Update Flight Fixture to "use client" instead of .client.js ([#26118](react/react#26118)) //<Sebastian Markbåge>// - **[03a2160](react/react@03a216070 )**: Rename "dom" fork to "dom-node" and "bun" fork to "dom-bun" ([#26117](react/react#26117)) //<Sebastian Markbåge>// - **[4bf2113](react/react@4bf2113a1 )**: Revert "Move the Webpack manifest config to one level deeper ([#26083](react/react#26083))" ([#26111](react/react#26111)) //<Sebastian Markbåge>// - **[2ef2414](react/react@2ef24145e )**: [flow] upgrade to 0.199.0 ([#26096](react/react#26096)) //<Jan Kassens>// - **[922dd7b](react/react@922dd7ba5 )**: Revert the outer module object to an object ([#26093](react/react#26093)) //<Sebastian Markbåge>// - **[9d111ff](react/react@9d111ffdf )**: Serialize Promises through Flight ([#26086](react/react#26086)) //<Sebastian Markbåge>// - **[0ba4698](react/react@0ba4698c7 )**: Fix async test in React reconciler ([#26087](react/react#26087)) //<Ming Ye>// - **[8c234c0](react/react@8c234c0de )**: Move the Webpack manifest config to one level deeper ([#26083](react/react#26083)) //<Sebastian Markbåge>// - **[977bccd](react/react@977bccd24 )**: Refactor Flight Encoding ([#26082](react/react#26082)) //<Sebastian Markbåge>// - **[d7bb524](react/react@d7bb524ad )**: [cleanup] Remove unused package jest-mock-scheduler ([#26084](react/react#26084)) //<Ming Ye>// - **[6b30832](react/react@6b3083266 )**: Upgrade prettier ([#26081](react/react#26081)) //<Jan Kassens>// - **[1f5ce59](react/react@1f5ce59dd )**: [cleanup] fully roll out warnAboutSpreadingKeyToJSX ([#26080](react/react#26080)) //<Jan Kassens>// Changelog: [General][Changed] - React Native sync for revisions 48b687f...fccf3a9 jest_e2e[run_all_tests] Reviewed By: rubennorte Differential Revision: D43305607 fbshipit-source-id: 8da7567ca2a182f4be27788935c2da30a731f83b
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
WithakErik
commented
Apr 28, 2025
Was this ever implemented? I've tried adding |
shuo-hiwintech
commented
Sep 25, 2025
Same problem. Have you made any progress? |
Summary
Adds Image Keyboard Support to
TextInputon Android. It adds theonImageInputprop which calls the callback and provides a local content uri, base64 encoded string of the image, mime type and possibly a url to the image on the web.Changelog
[Android] [Added] -
onImageInputprop to theTextInputcomponentTest Plan
Tested with Gboard, Fleksy and Tenor gif keyboard on android.