Skip to content

[Headers] Add an umbrella header for the library - #261

Closed
ide wants to merge 1 commit into
react:masterfrom
ide:umbrella-header
Closed

[Headers] Add an umbrella header for the library#261
ide wants to merge 1 commit into
react:masterfrom
ide:umbrella-header

Conversation

@ide

@ideide commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

The umbrella header allows projects that link React Native using CocoaPods to import it in standard fashion: #import <React/React.h>. Currently all of the headers are exported so that external projects can experiment.

@sahrens

Copy link
Copy Markdown
Contributor

cc @nicklockwood

@sahrens

Copy link
Copy Markdown
Contributor

cc @tadeuzagallo too.

@ide

ide commented Mar 31, 2015

Copy link
Copy Markdown
ContributorAuthor

This has been kind of hacked together as React Native has been refactored, so I think the concept stands but each library should have its own umbrella header, and then maybe have a master umbrella header that imports the core + ubiquitous libraries (text, image support but not geolocation, vibration, etc).

@tadeuzagallo

Copy link
Copy Markdown
Contributor

Sounds good. Everything that is non-optional is exposed in this header, and one more header per subspec.

The umbrella header allows projects that link React Native using CocoaPods to import it in standard fashion: `#import <React/React.h>`. Currently all of the headers are exported so that external projects can experiment.
Generated with:
find React -name "*.h" | awk -F'/' '{print "#import <React/"$NF">"}' > React/React.h
@ideide closed this Apr 1, 2015
@ide
ide deleted the umbrella-header branch April 1, 2015 06:44
@ide
ide restored the umbrella-header branch April 1, 2015 06:44
facebook-github-bot pushed a commit that referenced this pull request Jan 17, 2017
Summary:
Fixes#261Closesreact/yoga#262
Reviewed By: splhack
Differential Revision: D4245200
Pulled By: emilsjolander
fbshipit-source-id: 77d802d71010ed426511d6a01e6de1e7c9194179
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Mar 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ide@sahrens@tadeuzagallo