lazy configure ReactAndroid gradle tasks by dulmandakh · Pull Request #26314 · react/react-native

dulmandakh · 2019-09-03T20:30:21Z

Summary

ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from android when it wasn't configured completely.

extensionSupplier.get()!!.compileSdkVersionmustnotbenull

or

compileSdkVersionisnotspecified.

It is happening because buildReactNdkLib task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from android when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically.

Changelog

[Android] [Changed] - lazily configure ReactAndroid gradle tasks

Test Plan

./gradlew ReactAndroid:tasks run without errors, while master throws exception.

dulmandakh · 2019-09-03T20:35:55Z

@friederbluemle @gengjiawen please review

friederbluemle · 2019-09-03T21:56:21Z

Awesome, it's working for me locally! 👍 Thanks @dulmandakh 🎉

dulmandakh · 2019-09-04T02:30:11Z

@friederbluemle please approve it if it worked 😉

mdvacca

accepting and landing it

facebook-github-bot

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

friederbluemle

👍

dulmandakh · 2019-09-05T04:27:21Z

@mdvacca any news?

mdvacca · 2019-09-05T04:37:59Z

trying one more time...

Summary: Gradle wrapper `5.6.2` Supersedes and closes#26227 ## Changelog [Android] [Changed] - Gradle wrapper 5.6.2 Pull Request resolved: #26349 Test Plan: Builds successfully (just like the current `master` branch, **only** after either reverting 4763000 **or** cherry-picking 7f23878 from #26314) Differential Revision: D17224299 Pulled By: mdvacca fbshipit-source-id: cbd1b3d5d686e284fdc8e3f6faaeaa93654b301d

mdvacca · 2019-09-06T20:26:30Z

@dulmandakh this PR keeps failing with the following error:

What went wrong:
Could not determine the dependencies of task ':ReactAndroid:packageReactNdkLibs'.

Could not create task ':ReactAndroid:buildReactNdkLib'.
NDK is not installed

I think the change from Line 213 is affecting the build?

friederbluemle · 2019-09-07T07:24:55Z

@mdvacca - Which task are you running that is failing?

dulmandakh · 2019-09-09T19:35:26Z

@mdvacca please make sure that you have NDK installed and ANDROID_NDK environment variable points to it.

dulmandakh · 2019-09-10T12:12:46Z

@mdvacca the :ReactAndroid:buildReactNdkLib task works as expected if NDK is set

dulmandakh · 2019-09-16T13:25:25Z

@cpojer please merge

dulmandakh · 2019-09-18T07:45:49Z

@mdvacca @cpojer please review and merge. I'm working on other gradle improvements, and I need it.

friederbluemle · 2019-09-18T08:04:58Z

I just tested this again, and it (still) works. 👍

cpojer · 2019-09-18T08:43:37Z

@dulmandakh CI is failing with the same error @mdvacca mentioned above. Could you fix that first?

dulmandakh · 2019-09-18T09:04:47Z

@cpojer sorry, fixed. I'm working to add Gradle builds to CI #26482

cpojer

Let's try it.

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2019-09-18T09:35:08Z

This pull request was successfully merged by @dulmandakh in 7c8e266.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: react#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c (cherry picked from commit 7c8e266)

Summary: ReactAndroid Gradle was failing mysteriously with error below, because it was trying to read values from **android** when it wasn't configured completely. ```java extensionSupplier.get()!!.compileSdkVersion must not be null ``` or ```java compileSdkVersion is not specified. ``` It is happening because **buildReactNdkLib** task was created and configured eagerly. So this PR changes some tasks to be configured lazily, and reads values from **android** when ready. Also remove ANDROID_NDK variable check because android gradle plugin doing it automatically. ## Changelog [Android] [Changed] - lazily configure ReactAndroid gradle tasks Pull Request resolved: react#26314 Test Plan: ./gradlew ReactAndroid:tasks run without errors, while master throws exception. Differential Revision: D17177945 Pulled By: cpojer fbshipit-source-id: c7a165092157d2059f946da70b801d1a475d4b8c

lazy configure ReactAndroid gradle tasks
7f23878

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 3, 2019

dulmandakh requested a review from cpojer September 3, 2019 20:30

react-native-bot added the Platform: Android Android applications. label Sep 3, 2019

gengjiawen reviewed Sep 4, 2019
View reviewed changes

Comment threadReactAndroid/build.gradle

mdvacca approved these changes Sep 4, 2019
View reviewed changes

facebook-github-bot approved these changes Sep 4, 2019
View reviewed changes

gengjiawen approved these changes Sep 4, 2019
View reviewed changes

friederbluemle approved these changes Sep 4, 2019
View reviewed changes

friederbluemle mentioned this pull request Sep 5, 2019
Update Gradle wrapper to 5.6.2 #26349
Closed

Merge branch 'master' into lazy-gradle-tasks
012023b

Merge branch 'master' into lazy-gradle-tasks
4380b07

revert back ANDROID_NDK check
8510ad2

cpojer approved these changes Sep 18, 2019
View reviewed changes

facebook-github-bot approved these changes Sep 18, 2019
View reviewed changes

facebook-github-bot closed this in 7c8e266Sep 18, 2019

react-native-bot added the Merged This PR has been merged. label Sep 18, 2019

dulmandakh deleted the lazy-gradle-tasks branch October 15, 2019 05:13

Uh oh!

Conversation

dulmandakh commented Sep 3, 2019

Summary

Changelog

Test Plan

Uh oh!

dulmandakh commented Sep 3, 2019

Uh oh!

friederbluemle commented Sep 3, 2019

Uh oh!

Uh oh!

dulmandakh commented Sep 4, 2019

Uh oh!

mdvacca left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

friederbluemle left a comment

Choose a reason for hiding this comment

Uh oh!

dulmandakh commented Sep 5, 2019

Uh oh!

mdvacca commented Sep 5, 2019

Uh oh!

mdvacca commented Sep 6, 2019

Uh oh!

friederbluemle commented Sep 7, 2019

Uh oh!

dulmandakh commented Sep 9, 2019

Uh oh!

dulmandakh commented Sep 10, 2019

Uh oh!

dulmandakh commented Sep 16, 2019

Uh oh!

dulmandakh commented Sep 18, 2019

Uh oh!

friederbluemle commented Sep 18, 2019

Uh oh!

cpojer commented Sep 18, 2019

Uh oh!

dulmandakh commented Sep 18, 2019

Uh oh!

cpojer left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

react-native-bot commented Sep 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants