Uh oh!
There was an error while loading. Please reload this page.
Fix cursorColor on Android Q+ - #26433
Closed
janicduplessis wants to merge 7 commits into
Closed
Conversation
cursorColor on Android Q+cursorColor on Android Q+janicduplessis
commented
Jan 31, 2020
ContributorAuthor
Now that we compile with sdk 29 this should be mergeable. |
janicduplessis
commented
Jan 31, 2020
ContributorAuthor
Buck wasn't compiling using sdk 29 like gradle. Updated 7e4a71b and it seems to build fine on CI now. We probably want to land this in a separate commit and idk if this will affect fb. |
janicduplessis
commented
Jan 31, 2020
ContributorAuthor
dulmandakh
commented
Feb 1, 2020
via email
Contributor
LGTM. I would bump target to android-29. |
mdvacca
commented
Feb 1, 2020
Contributor
LGTM, importing to review and test internally |
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
janicduplessis
commented
Mar 11, 2020
ContributorAuthor
ping @mdvacca |
janicduplessis
commented
Apr 5, 2020
ContributorAuthor
facebook-github-bot pushed a commit
that referenced
this pull request
Mar 29, 2023
Summary: This sync includes the following changes: - **[77ba161](react/react@77ba1618a )**: Bugfix: Remove extra render pass when reverting to client render ([#26445](react/react#26445)) //<Andrew Clark>// - **[520f7f3](react/react@520f7f3ed )**: Refactor ReactDOMComponent to use flatter property operations ([#26433](react/react#26433)) //<Sebastian Markbåge>// - **[0131d0c](react/react@0131d0cff )**: Check if suspensey instance resolves in immediate task ([#26427](react/react#26427)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 3554c88...77ba161 jest_e2e[run_all_tests] Reviewed By: poteto Differential Revision: D44476026 fbshipit-source-id: c6935d760a068672b714722dee1fd24839c08c4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursorColoris broken since android P restricted access to private APIs. Luckily Android added a new API in Android Q to set the cursor drawable programmatically. Sadly it will stay broken for Android P and O but at least it will work going forward. I still kept the reflection implementation for now, we might want to drop it at some point.Before landing this we need to bump the compile sdk version to SDK 29. This should not be done in this PR.
Changelog
[Android] [Fixed] - Fix
cursorColoron Android Q+Test Plan
Added an example in RNTester and checked that it works on an Android Q simulator.