Uh oh!
There was an error while loading. Please reload this page.
[TextInput] returnKeyType, enablesReturnKeyAutomatically, secureTextEntry, more keyboardTypes - #265
Closed
ide wants to merge 1 commit into
Closed
[TextInput] returnKeyType, enablesReturnKeyAutomatically, secureTextEntry, more keyboardTypes#265ide wants to merge 1 commit into
ide wants to merge 1 commit into
Conversation
…ntry more keyboardTypes This diff completes adding support for the following UITextField properties: returnKeyType: what the return key on the keyboard says enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously. secureTextEntry: obscure passwords keyboardType: added all the keyboard types, they are useful in different scenarios There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here. Added examples to the UIExplorer.
ide
commented
Mar 26, 2015
ContributorAuthor
Fixes the secure text field request in #245 |
a2
commented
Mar 26, 2015
Contributor
I CANT USE PHABRICATOR MACROS HERE MY POWERS ARE USELESS |
ide
commented
Mar 26, 2015
ContributorAuthor
@a2 awesometown I would be 80% serious if I said to move the code review off of GitHub and onto Phabricator. Phacility has done a really great job making the flow intuitive compared to other products. |
sophiebits
commented
Mar 26, 2015
Contributor
@ide Yeah, hhvm uses Phabricator (reviews.facebook.net) now and it's something we could look at doing here and on React too. |
vjeux
commented
Mar 28, 2015
Contributor
This has been requested many times, need to merge it asap |
tadeuzagallo
commented
Mar 31, 2015
Contributor
Landed internally, will be out on the next sync |
ide
commented
Mar 31, 2015
ContributorAuthor
Thanks for the code review guys |
This was referenced Apr 1, 2015
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
…ntry, more keyboardTypes Summary: This diff completes adding support for the following UITextField properties: - returnKeyType: what the return key on the keyboard says - enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously. - secureTextEntry: obscure passwords - keyboardType: added all the keyboard types, they are useful in different scenarios There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here. Added examples to the UIExplorer. Closesreact#265 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
mrtom
commented
Apr 14, 2015
a2
commented
Apr 14, 2015
Contributor
It should have been synced by now? |
tadeuzagallo
commented
Apr 14, 2015
Contributor
Yes, it was synced on 9a4ee17 |
mrtom
commented
Apr 14, 2015
But that's not been pushed out via NPM, right? |
mrtom
commented
Apr 14, 2015
Ignore me, I'm being a muppet... Sorry! |
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
…ntry, more keyboardTypes Summary: This diff completes adding support for the following UITextField properties: - returnKeyType: what the return key on the keyboard says - enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously. - secureTextEntry: obscure passwords - keyboardType: added all the keyboard types, they are useful in different scenarios There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here. Added examples to the UIExplorer. Closesreact#265 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
…ntry, more keyboardTypes Summary: This diff completes adding support for the following UITextField properties: - returnKeyType: what the return key on the keyboard says - enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously. - secureTextEntry: obscure passwords - keyboardType: added all the keyboard types, they are useful in different scenarios There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here. Added examples to the UIExplorer. Closesreact#265 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
billinghamj
commented
Oct 27, 2015
Any chance you guys could work publicly on github rather than syncing from an internal repo? |
sophiebits
commented
Oct 27, 2015
Contributor
Internal commits are now synced out within minutes so there's not a huge difference. |
react-one pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff completes adding support for the following UITextField properties:
There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.
Added examples to the UIExplorer.