Uh oh!
There was an error while loading. Please reload this page.
Remove JS autoFocus implementation - #27923
Closed
janicduplessis wants to merge 1 commit into
Closed
Conversation
janicduplessisforce-pushed
the
autofocus-native-2
branch
from
February 1, 2020 01:17
6749fd2 to
3ba7ac2Compareelicwhite
self-requested a review
February 1, 2020 01:20
elicwhite
commented
Feb 3, 2020
Contributor
Remind me to land this on February 10th |
ecreeth
commented
Feb 10, 2020
Contributor
Ping! @TheSavior |
Contributor
Thanks for the ping! Looks like I can't land this yet. Let's check again on 2/17! 😀 |
ecreeth
commented
Feb 17, 2020
Contributor
I'M a bot 😆 Ping! @TheSavior |
janicduplessis
commented
Feb 17, 2020
ContributorAuthor
😄 thanks @ecreeth |
elicwhite
commented
Feb 18, 2020
Contributor
Thanks for the pings! |
facebook-github-bot
approved these changes
Feb 18, 2020
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
Mar 2, 2020
Collaborator
This pull request was successfully merged by @janicduplessis in 0569d4c. When will my fix make it into a release? | Upcoming Releases |
elicwhite
commented
Mar 2, 2020
Contributor
Yay! |
osdnk pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Follow up to react#27803 and react#27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now. ## Changelog [General] [Fixed] - Remove JS autoFocus implementation Pull Request resolved: react#27923 Test Plan: Test that focus works in RN Tester with this, react#27803 and react#27924 Differential Revision: D19956373 Pulled By: TheSavior fbshipit-source-id: 5d99ead55011663b3edaf499ac7616765a24cb50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #27803 and #27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now.
Changelog
[General] [Fixed] - Remove JS autoFocus implementation
Test Plan
Test that focus works in RN Tester with this, #27803 and #27924