Skip to content

Update Android Gradle plugin to 3.6.4 - #28170

Closed
friederbluemle wants to merge 1 commit into
react:masterfrom
friederbluemle:update-gradle-plugin
Closed

Update Android Gradle plugin to 3.6.4#28170
friederbluemle wants to merge 1 commit into
react:masterfrom
friederbluemle:update-gradle-plugin

Conversation

@friederbluemle

@friederbluemlefriederbluemle commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

Summary

Android Studio 3.6.3 is now available in the stable channel

https://androidstudio.googleblog.com/2020/04/android-studio-363-available.html

EDIT: Another patch update to 3.6.4 was released in July 2020:

This minor update supports compatibility with new default settings and features for package visibility in Android 11.

Details: https://developer.android.com/studio/releases/gradle-plugin#3-6-0

Changelog

[Android] [Changed] - Update Android Gradle plugin to 3.6.4

Test Plan

Build project

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2020
@react-native-botreact-native-bot added the Platform: Android Android applications. label Feb 25, 2020
@analysis-bot

Copy link
Copy Markdown

RNTester (Android/hermes/arm64-v8a): 3289088 bytes
RNTester (Android/hermes/armeabi-v7a): 3129344 bytes
RNTester (Android/hermes/x86): 3461120 bytes
RNTester (Android/hermes/x86_64): 3424256 bytes
RNTester (Android/jsc/arm64-v8a): 4444160 bytes
RNTester (Android/jsc/armeabi-v7a): 4265984 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

@analysis-bot

Copy link
Copy Markdown

RNTester.app (iOS): 10657792 bytes

@dulmandakhdulmandakh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friederbluemlefriederbluemle changed the title Update Android Gradle plugin to 3.6.0Update Android Gradle plugin to 3.6.1Feb 28, 2020
@analysis-bot

analysis-bot commented Mar 27, 2020

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,001,749-2,798
androidhermesarmeabi-v7a6,665,705-2,805
androidhermesx867,422,065-2,799
androidhermesx86_647,312,947-2,798
androidjscarm64-v8a9,161,574-2,806
androidjscarmeabi-v7a8,817,666-2,788
androidjscx869,009,982-2,788
androidjscx86_649,587,060-2,792

Base commit: 0056357

@analysis-bot

analysis-bot commented Mar 27, 2020

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 0056357

@friederbluemlefriederbluemle changed the title Update Android Gradle plugin to 3.6.1Update Android Gradle plugin to 3.6.2Apr 1, 2020
@friederbluemle

Copy link
Copy Markdown
ContributorAuthor

Rebased and updated to 3.6.2

@SaeedZhiany

Copy link
Copy Markdown
Contributor

@friederbluemle

Android Studio 3.6.3 has been released. please rebase and update this.

@friederbluemle

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reminder @SaeedZhiany

@friederbluemlefriederbluemle changed the title Update Android Gradle plugin to 3.6.2Update Android Gradle plugin to 3.6.3Apr 20, 2020
@SaeedZhiany

Copy link
Copy Markdown
Contributor

@friederbluemle

Android Studio 4.0.0 has been released. please rebase again. (or it's better to create another PR and check the possible break changes due to the major release?)

@friederbluemle

Copy link
Copy Markdown
ContributorAuthor

Thanks @SaeedZhiany - Funny, I was actually looking into this right as you commented :D

It makes sense, I think 4.0.0 needs to be tested separately (#29013) - Meanwhile, I hope this PR here can be merged soon (has been approved a while ago). I just rebased it and resolved the conflict.

@friederbluemlefriederbluemle changed the title Update Android Gradle plugin to 3.6.3Update Android Gradle plugin to 3.6.4Aug 24, 2020
@friederbluemle

Copy link
Copy Markdown
ContributorAuthor

Rebased and updated to 3.6.4.

@facebook-github-botfacebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fkgozali

Copy link
Copy Markdown
Contributor

FYI, I updated the PR internally to also upgrade the ones used in https://github.com/facebook/react-native/tree/master/packages/react-native-codegen/android

@friederbluemle

Copy link
Copy Markdown
ContributorAuthor

Thanks @fkgozali

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @friederbluemle in cf8368f.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Aug 27, 2020
@friederbluemle
friederbluemle deleted the update-gradle-plugin branch September 1, 2020 22:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Platform: AndroidAndroid applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@friederbluemle@analysis-bot@SaeedZhiany@fkgozali@react-native-bot@dulmandakh@facebook-github-bot