Fix dashed/dotted border drawing when border-radius is 0

[IjzerenHein]

Summary

This PR fixes the border-style that is not respected when drawing a border with 0 border-radius on Android. This would cause the faster drawRectangularBackgroundWithBorders path to be used, but that uses rectangular drawing and doesn't support dashed/dotted stroke patterns.
This PR changes the behavior to use the generic drawRoundedBackgroundWithBorders code-path which does support dashed/dotted border-styles.

Changelog

[Android] [Fixed] - Fix dashed/dotted border-drawing when border-radius is 0

Test Plan

Faulty situation:

After the fix:

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	10,903,792	0

Base commit: 25ed045

[facebook-github-bot]

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[shergin]

Internal CI tests failed because of:

java.lang.NullPointerException: Attempt to read from field 'boolean android.graphics.Path.isSimplePath' on a null object reference
at android.graphics.BaseCanvas.drawPath(BaseCanvas.java:295)
at android.graphics.Canvas.drawPath(Canvas.java:1652)
at com.facebook.react.views.view.ReactViewBackgroundDrawable.drawRoundedBackgroundWithBorders(ReactViewBackgroundDrawable.java:338)
at com.facebook.react.views.view.ReactViewBackgroundDrawable.draw(ReactViewBackgroundDrawable.java:134)
at android.view.View.drawBackground(View.java:19399)
at android.view.View.draw(View.java:19183)
at android.view.View.draw(View.java:19062)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at com.facebook.react.ReactRootView.dispatchDraw(ReactRootView.java:229)
at android.view.View.draw(View.java:19060)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at com.facebook.react.testing.ScreenshotingFrameLayout.dispatchDraw(ScreenshotingFrameLayout.java:44)
at android.view.View.updateDisplayListIfDirty(View.java:18133)
at android.view.View.draw(View.java:18920)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at android.view.View.updateDisplayListIfDirty(View.java:18133)
at android.view.View.draw(View.java:18920)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at android.view.View.updateDisplayListIfDirty(View.java:18133)
at android.view.View.draw(View.java:18920)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at android.view.View.updateDisplayListIfDirty(View.java:18133)
at android.view.View.draw(View.java:18920)
at android.view.ViewGroup.drawChild(ViewGroup.java:4236)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4022)
at android.view.View.draw(View.java:19195)
at com.android.internal.policy.DecorView.draw(DecorView.java:788)
at android.view.View.updateDisplayListIfDirty(View.java:18142)
at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:669)
at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:675)
at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:783)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:2992)
at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2806)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2359)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1392)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6752)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:911)
at android.view.Choreographer.doCallbacks(Choreographer.java:723)
at android.view.Choreographer.doFrame(Choreographer.java:658)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

@IjzerenHein Could you please figure it out?

[IjzerenHein]

@shergin Which test specifically is failing? How can I run that test?

When I look at the CI Android tests, they seem to fail at:

+ buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
Not using buckd because watchman isn't installed.
Picked up _JAVA_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap
PARSING BUCK FILES: FINISHED IN 1.4s
Buck wasn't able to parse /root/react-native/ReactAndroid/src/main/java/com/facebook/fbreact/specs/BUCK:
KeyError: 'load label @fbsource//tools/build_defs:platform_defs.bzl references an unknown cell named fbsource known cells: {}'
Call stack:
File "/root/react-native/.buckd/resources/2019.10.17.01/buck_server/buck_parser/profiler.py", line 507, in wrapped
return func(*args, **kwargs)
File "/root/react-native/ReactAndroid/src/main/java/com/facebook/fbreact/specs/BUCK", line 1
load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID")
This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook/fbreact/specs:FBReactNativeSpec' of target '//ReactAndroid/src/main/java/com/facebook/react/devsupport:devsupport'
Exited with code exit status 1

And when running test-android-all locally I also get this error:

Step 14/24 : RUN buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
---> Running in 4edb170a2f99
Not using buckd because watchman isn't installed.
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
PARSING BUCK FILES: FINISHED IN 2.7s
Buck wasn't able to parse /app/ReactAndroid/src/main/java/com/facebook/fbreact/specs/BUCK:
KeyError: 'load label @fbsource//tools/build_defs:platform_defs.bzl references an unknown cell named fbsource known cells: {}'
Call stack:
File "/app/.buckd/resources/2019.10.17.01/buck_server/buck_parser/profiler.py", line 507, in wrapped
return func(*args, **kwargs)
File "/app/ReactAndroid/src/main/java/com/facebook/fbreact/specs/BUCK", line 1
load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID")
This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook/fbreact/specs:FBReactNativeSpec' of target '//ReactAndroid/src/main/java/com/facebook/react/devsupport:devsupport'
The command '/bin/sh -c buck fetch ReactAndroid/src/test/java/com/facebook/react/modules' returned a non-zero code: 1

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,759,033	65
android	hermes	armeabi-v7a	6,406,070	60
android	hermes	x86	7,140,438	50
android	hermes	x86_64	7,031,771	66
android	jsc	arm64-v8a	8,927,827	60
android	jsc	armeabi-v7a	8,567,292	67
android	jsc	x86	8,752,388	77
android	jsc	x86_64	9,329,333	74

Base commit: 25ed045

[IjzerenHein]

@shergin I've rebased on master, all tests seem to pass. I was unable to reproduce/find the issue that you mentioned. Which test did you run?

[fabOnReact]

#29099

[facebook-github-bot]

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@charlesbdudley merged this pull request in 3e5998e.

[charlesbdudley]

Hi @IjzerenHein, unfortunately this merge was reverted as it caused crashes on physical devices. Interestingly we weren't able to reproduce it in a simulator. Do you have access to a physical device to try to reproduce this error?

java.lang.NullPointerException:com.facebook.react.views.view.ReactViewBackgroundDrawable.drawRoundedBackgroundWithBorders
stack_trace:	java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.NullPointerException: Attempt to read from field 'boolean android.graphics.Path.isSimplePath' on a null object reference
at com.facebook.react.bridge.ReactContext.handleException(ReactContext.java:425)
at com.facebook.react.views.modal.ReactModalHostView$DialogRootViewGroup.handleException(ReactModalHostView.java:508)
at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:749)
at android.view.View.updateDisplayListIfDirty(View.java:22762)
at android.view.View.draw(View.java:23631)
at android.view.ViewGroup.drawChild(ViewGroup.java:5336)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:5093)
at com.facebook.react.views.view.ReactViewGroup.dispatchDraw(ReactViewGroup.java:743)

[IjzerenHein]

@charlesbdudley Unfortunately I don't have any bandwidth available to look at this issue :/

[charlesbdudley]

@charlesbdudley Unfortunately I don't have any bandwidth available to look at this issue :/

No problem. I'm going to close this for now to focus on active PRs but feel free to mention me if your bandwidth changes and I'll open it back up!