Uh oh!
There was an error while loading. Please reload this page.
Inverted flatlist refresh control - #28857
Closed
awalmubarak wants to merge 5 commits into
Closed
Conversation
Base commit: aece57b |
facebook-github-bot
commented
May 8, 2020
Contributor
Hi @awalmubarak! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: aece57b |
elicwhite
commented
May 9, 2020
Contributor
I commented on the linked issue: #17553 (comment) |
Contributor
Thanks. I commented on the linked issue: #17553 (comment). I wish you a good weekend |
facebook-github-bot
commented
May 9, 2020
Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
commented
May 9, 2020
Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
awalmubarak
commented
May 9, 2020
Author
Thanks all. I commented on the linked Issue: #17553 (comment). Enjoy your weekend. |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
facebook-github-bot pushed a commit
that referenced
this pull request
Apr 19, 2024
Summary: This sync includes the changes from: - D56103750 - [TODO] A shim for SECRET_INTERNALS This sync includes the following changes: - **[b5e5ce8](react/react@b5e5ce8e0 )**: Update ReactNativeTypes for root options (part 2) ([#28857](react/react#28857)) //<Ricky>// - **[da6ba53](react/react@da6ba53b1 )**: [UMD] Remove umd builds ([#28735](react/react#28735)) //<Josh Story>// - **[0c245df](react/react@0c245df1d )**: Complete the typo fix ([#28856](react/react#28856)) //<Sebastian Silbermann>// - **[f82051d](react/react@f82051d7a )**: console test utils fix: match entire string, not just first letter ([#28855](react/react#28855)) //<Andrew Clark>// - **[4ca20fd](react/react@4ca20fd36 )**: Test top level fragment inside lazy semantics ([#28852](react/react#28852)) //<Sebastian Markbåge>// - **[c0cf7c6](react/react@c0cf7c696 )**: Promote ASYNC_ITERATOR symbol to React Symbols ([#28851](react/react#28851)) //<Sebastian Markbåge>// - **[657428a](react/react@657428a9e )**: Add ReactNativeTypes for root options ([#28850](react/react#28850)) //<Ricky>// - **[7909d8e](react/react@7909d8eab )**: [Flight] Encode ReadableStream and AsyncIterables ([#28847](react/react#28847)) //<Sebastian Markbåge>// - **[13eb61d](react/react@13eb61d05 )**: Move enableUseDeferredValueInitialArg to canary ([#28818](react/react#28818)) //<Andrew Clark>// - **[8afa144](react/react@8afa144bd )**: Enable flag disableClientCache ([#28846](react/react#28846)) //<Jan Kassens>// - **[734956a](react/react@734956ace )**: Devtools: Add support for useFormStatus ([#28413](react/react#28413)) //<Sebastian Silbermann>// - **[17e920c](react/react@17e920c00 )**: [Flight Reply] Encode Typed Arrays and Blobs ([#28819](react/react#28819)) //<Sebastian Markbåge>// - **[0347fcd](react/react@0347fcd00 )**: Add on(Caught|Uncaught|Recoverable) opts to RN ([#28836](react/react#28836)) //<Ricky>// - **[c113503](react/react@c113503ad )**: Flush direct streams in Bun ([#28837](react/react#28837)) //<Kenta Iwasaki>// - **[9defcd5](react/react@9defcd56b )**: Remove redundant props assign ([#28829](react/react#28829)) //<Sebastian Silbermann>// - **[ed40236](react/react@ed4023603 )**: Fix mistaken "react-server" condition ([#28835](react/react#28835)) //<Sebastian Markbåge>// - **[c8a0350](react/react@c8a035036 )**: [Fizz] hoistables should never flush before the preamble ([#28802](react/react#28802)) //<Josh Story>// - **[4f5c812](react/react@4f5c812a3 )**: DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions ([#28593](react/react#28593)) //<Sebastian Silbermann>// - **[4354159](react/react@435415962 )**: Backwards compatibility for string refs on WWW ([#28826](react/react#28826)) //<Jack Pope>// - **[608edcc](react/react@608edcc90 )**: [tests] add `assertConsole<method>Dev` helpers ([#28732](react/react#28732)) //<Ricky>// - **[da69b6a](react/react@da69b6af9 )**: ReactDOM.requestFormReset ([#28809](react/react#28809)) //<Andrew Clark>// - **[374b5d2](react/react@374b5d26c )**: Scaffolding for requestFormReset API ([#28808](react/react#28808)) //<Andrew Clark>// - **[41950d1](react/react@41950d14a )**: Automatically reset forms after action finishes ([#28804](react/react#28804)) //<Andrew Clark>// - **[dc6a7e0](react/react@dc6a7e01e )**: [Float] Don't preload images inside `<noscript>` ([#28815](react/react#28815)) //<Josh Story>// - **[3f947b1](react/react@3f947b1b4 )**: [tests] Assert scheduler log empty in internalAct ([#28737](react/react#28737)) //<Ricky>// - **[bf09089](react/react@bf09089f6 )**: Remove Scheduler.log from ReactSuspenseFuzz-test ([#28812](react/react#28812)) //<Ricky>// - **[84cb3b4](react/react@84cb3b4cb )**: Hardcode disableIEWorkarounds for www ([#28811](react/react#28811)) //<Ricky>// - **[2243b40](react/react@2243b40ab )**: [tests] assertLog before act in useEffectEvent ([#28763](react/react#28763)) //<Ricky>// - **[dfc64c6](react/react@dfc64c6e3 )**: [tests] assertLog before act in ReactUse ([#28762](react/react#28762)) //<Ricky>// - **[42eff4b](react/react@42eff4bc7 )**: [tests] Fix assertions not flushed before act ([#28745](react/react#28745)) //<Ricky>// - **[ed3c65c](react/react@ed3c65caf )**: Warn if outdated JSX transform is detected ([#28781](react/react#28781)) //<Andrew Clark>// - **[3f9e237](react/react@3f9e237a2 )**: Fix: Suspend while recovering from hydration error ([#28800](react/react#28800)) //<Andrew Clark>// - **[7f5d25e](react/react@7f5d25e23 )**: Fix cloneElement using string ref w no owner ([#28797](react/react#28797)) //<Joseph Savona>// - **[bf40b02](react/react@bf40b0244 )**: [Fizz] Stop publishing external-runtime to stable channel ([#28796](react/react#28796)) //<Josh Story>// - **[7f93cb4](react/react@7f93cb41c )**: [DOM] Infer react-server entries bundles if not explicitly configured ([#28795](react/react#28795)) //<Josh Story>// - **[f613165](react/react@f61316535 )**: Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([#28789](react/react#28789)) //<Sebastian Markbåge>// - **[9644d20](react/react@9644d206e )**: Soften useFormState warning ([#28788](react/react#28788)) //<Ricky>// - **[c771016](react/react@c771016e1 )**: Rename The Secret Export of Server Internals ([#28786](react/react#28786)) //<Sebastian Markbåge>// - **[d50323e](react/react@d50323eb8 )**: Flatten ReactSharedInternals ([#28783](react/react#28783)) //<Sebastian Markbåge>// - **[f62cf8c](react/react@f62cf8c62 )**: [Float] treat `props.async` in Float consistent with the rest of react-dom ([#26760](react/react#26760)) //<Josh Story>// - **[dfd3d5a](react/react@dfd3d5af8 )**: Add support for transition{run,start,cancel} events ([#27345](react/react#27345)) //<Hugo Sales>// - **[1f8327f](react/react@1f8327f83 )**: [Fiber] Use real event priority for hydration scheduling ([#28765](react/react#28765)) //<Josh Story>// - **[97c90ed](react/react@97c90ed88 )**: [DOM] Shrink ReactDOMCurrentDispatcher method names ([#28770](react/react#28770)) //<Josh Story>// - **[9007fdc](react/react@9007fdc8f )**: [DOM] Shrink ReactDOMSharedInternals source representation ([#28771](react/react#28771)) //<Josh Story>// - **[14f50ad](react/react@14f50ad15 )**: [Flight] Allow lazily resolving outlined models ([#28780](react/react#28780)) //<Sebastian Markbåge>// - **[4c12339](react/react@4c12339ce )**: [DOM] move `flushSync` out of the reconciler ([#28500](react/react#28500)) //<Josh Story>// - **[8e1462e](react/react@8e1462e8c )**: [Fiber] Move updatePriority tracking to renderers ([#28751](react/react#28751)) //<Josh Story>// - **[0b3b8a6](react/react@0b3b8a6a3 )**: jsx: Remove unnecessary hasOwnProperty check ([#28775](react/react#28775)) //<Andrew Clark>// - **[2acfb7b](react/react@2acfb7b60 )**: [Flight] Support FormData from Server to Client ([#28754](react/react#28754)) //<Sebastian Markbåge>// - **[d1547de](react/react@d1547defe )**: Fast JSX: Don't clone props object ([#28768](react/react#28768)) //<Andrew Clark>// - **[bfd8da8](react/react@bfd8da807 )**: Make class prop resolution faster ([#28766](react/react#28766)) //<Andrew Clark>// - **[cbb6f2b](react/react@cbb6f2b54 )**: [Flight] Support Blobs from Server to Client ([#28755](react/react#28755)) //<Sebastian Markbåge>// - **[f33a6b6](react/react@f33a6b69c )**: Track Owner for Server Components in DEV ([#28753](react/react#28753)) //<Sebastian Markbåge>// - **[e3ebcd5](react/react@e3ebcd54b )**: Move string ref coercion to JSX runtime ([#28473](react/react#28473)) //<Andrew Clark>// - **[fd0da3e](react/react@fd0da3eef )**: Remove _owner field from JSX elements in prod if string refs are disabled ([#28739](react/react#28739)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions 48b4ecc...b5e5ce8 jest_e2e[run_all_tests] bypass-github-export-checks Reviewed By: kassens Differential Revision: D56251607 fbshipit-source-id: e16db2fa101fc7ed1e009158c76388206beabd5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This add a quick fixissue #17553 on showing the refresh control at the top when Flatlist is INVERTED. A prop named invertedRefreshControlUp has been added to control whether refresh control will be displayed at the top or not when FlatList is Inverted
Changelog
[General] [Added] - Add invertedRefreshControlUp prop to Flatlist component
Test Plan
Add prop to RNTester and below is a video demo