Uh oh!
There was an error while loading. Please reload this page.
[Android] do not call setHyphenationFrequency on AndroidSdk < 23 - #29258
Closed
fabOnReact wants to merge 1 commit into
Closed
[Android] do not call setHyphenationFrequency on AndroidSdk < 23#29258fabOnReact wants to merge 1 commit into
fabOnReact wants to merge 1 commit into
Conversation
analysis-bot
commented
Jul 1, 2020
Base commit: e261f02 |
analysis-bot
commented
Jul 1, 2020
Base commit: e261f02 |
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mdvacca
commented
Jul 1, 2020
Contributor
@fabriziobertoglio1987 can you update the documentation with this change as well? |
1 similar comment
mdvacca
commented
Jul 1, 2020
Contributor
@fabriziobertoglio1987 can you update the documentation with this change as well? |
react-native-bot
commented
Jul 2, 2020
Collaborator
This pull request was successfully merged by @fabriziobertoglio1987 in 7d8aeb4. When will my fix make it into a release? | Upcoming Releases |
ContributorAuthor
Thanks a lot! react/react-native-website#2007 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@JoshuaGross This issue fixes#28279 as discussed in #29157 (comment)
Avoid calling setHyphenationFrequency on Android Sdk < 23.
Changelog
[Android] [Fixed] - do not call setHyphenationFrequency on AndroidSdk < 23
Test Plan
The warning displayed with
adb logcat | grep -P "ReactTextAnchorViewManager"I remain available to do improvements. Thanks a lot. Fabrizio.