Skip to content

Update reference to statusBarTranslucent in Modal comment - #29278

Closed
levibuzolic wants to merge 1 commit into
react:mainfrom
levibuzolic:patch-2
Closed

Update reference to statusBarTranslucent in Modal comment#29278
levibuzolic wants to merge 1 commit into
react:mainfrom
levibuzolic:patch-2

Conversation

@levibuzolic

Copy link
Copy Markdown
Contributor

The comment that points to the documentation for statusBarTranslucent was pointing to the incorrect property.

Summary

Noticed the link to the documentation was incorrect when making this change to the docs: react/react-native-website#2023

Changelog

[Internal] [Fixed] - Updated comment in Modal to point to the correct section of the documentation for statusBarTranslucent property

Test Plan

N/A

The comment that points to the documentation for statusBarTranslucent was pointing to the incorrect property.
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2020
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a6,763,5230
androidhermesarmeabi-v7a6,426,5990
androidhermesx867,151,2800
androidhermesx86_647,041,1950
androidjscarm64-v8a8,935,4660
androidjscarmeabi-v7a8,590,9440
androidjscx868,766,3420
androidjscx86_649,341,9050

Base commit: 4716d22

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 4716d22

@mdvaccamdvacca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-botfacebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Dec 9, 2022
Summary:
Re-apply #29278 that was recently closed by still valid.
Changelog:
[Internal] [Changed] - Update reference to statusBarTranslucent in Modal comment
Reviewed By: christophpurrer
Differential Revision: D41765526
fbshipit-source-id: 0397e86aa9adc5e5495cad8e2612cc5457840273
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@levibuzolic@analysis-bot@mdvacca@facebook-github-bot@sota000@react-native-bot