[Android] keyboardDidHide wrong screenY coordinates with windowTranslucentStatus=true

[fabOnReact]

Summary

This issue fixes#27526fixes#30052, related issue #27089
Avoid returning the wrong screenY coordinates on event keyboardDidHide.
getWindowVisibleDisplayFrame retrieves the overall visible display size in which the window this view is attached to has been positioned in. This takes into account screen decorations above the window, for both cases where the window itself is being position inside of them or the window is being placed under then and covered insets are used for the window to position its content inside. In effect, this tells you the available area where content can be placed and remain visible to users, since anything below the StatusBar is not visible to the user, the method does not work with translucent StatusBar (android:windowTranslucentStatus).

This commit fixes this issues removing the white bar at the bottom of the view when using windowTranslucentStatus.

Changelog

[Android] [Fixed] - keyboardDidHide wrong screenY coordinates with windowTranslucentStatus=true

Test Plan

Works in all scenarios, but I did not change RNTester windowTranslucentStatus. I would like to discuss the potential breaking changes connected to not using getWindowVisibleDisplayFrame with keyboardDidHide.

I would be happy to build an alternative functionality to calculate the WindowVisibleDisplayFrameHeight under request from the Facebook Team.

WITHOUTandroid:windowTranslucentStatus

BEFORE

AFTER

WITHandroid:windowTranslucentStatus

BEFORE

BEFORE (log)

AFTER

AFTER (log)

RNTester WITHOUTandroid:windowTranslucentStatus

BEFORE	AFTER

I remain available to do improvements. Thanks a lot. Fabrizio.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,763,750	107
android	hermes	armeabi-v7a	6,426,685	83
android	hermes	x86	7,151,383	100
android	hermes	x86_64	7,041,303	100
android	jsc	arm64-v8a	8,935,703	100
android	jsc	armeabi-v7a	8,591,045	98
android	jsc	x86	8,766,446	85
android	jsc	x86_64	9,342,008	100

Base commit: e23e932

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: e23e932

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[mdvacca]

Importing to review

[react-native-bot]

This pull request was successfully merged by @fabriziobertoglio1987 in 45954ac.

^{When will my fix make it into a release? | Upcoming Releases}

[fabOnReact]

Thanks a lot David Vacca 🙏

[andres-torres-marroquin]

This fix breaks the keyboardDidHide event in Android by sending screenY a value that is not correct, it basically crops the view at about 90% of the original height when the keyboard is hidden. I've tested 0.63.3 and 0.63.2, and the 0.63.2 works as intended. I'm using react-native-navigation with TopBar and BottomTabs, if that helps.

I just want to be sure if this change is actually correct?

[fabOnReact]

@andres-torres-marroquin I'll check into it this weekend, could you open and issue in react-native and reference this pr?
The issues needs to have a minimum reproducible example. Thanks a lot 🙏