Skip to content

Added examples to test tapping on overflowed Views to RNTesterApp - #29393

Closed
hsource wants to merge 1 commit into
react:mainfrom
wanderlog:harry-overflow-examples
Closed

Added examples to test tapping on overflowed Views to RNTesterApp#29393
hsource wants to merge 1 commit into
react:mainfrom
wanderlog:harry-overflow-examples

Conversation

@hsource

@hsourcehsource commented Jul 16, 2020

Copy link
Copy Markdown
Contributor

Summary

By default, Views in React Native have overflow: visible. When a child view is outside of the parent view's boundaries, it's visible on Android, but not tappable. This behaviour is incorrect, and doesn't match iOS behaviour.

#26374 and #29039 both fix this. @sherginsuggested:

Can we start from decoupling the example from this diff for quick landing? We think we solved this issue in Fabric on iOS and Android, and the test will be very helpful to verify that.

This change does that.

Changelog

[Internal] [Added] - Added examples to test tapping on overflowed Views to RNTesterApp

Test Plan

Added tests to RNTesterApp. Here are the current results of testing on Android:

masterWith #29039With #26374
20200716_01141720200716_01313620200716_013937

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2020
@react-native-botreact-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Jul 16, 2020
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a6,765,114991
androidhermesarmeabi-v7a6,432,725984
androidhermesx867,152,808991
androidhermesx86_647,042,8191,005
androidjscarm64-v8a8,936,208513
androidjscarmeabi-v7a8,596,204505
androidjscx868,767,008516
androidjscx86_649,342,651506

Base commit: 9f699ae

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 9f699ae

@hsourcehsource changed the title Added examples to test tapping on overflowed Views to RNTesterApp(Android) Added examples to test tapping on overflowed Views to RNTesterAppAug 13, 2020
@hsourcehsource changed the title (Android) Added examples to test tapping on overflowed Views to RNTesterAppAdded examples to test tapping on overflowed Views to RNTesterAppAug 14, 2020
@mrousavy

Copy link
Copy Markdown
Contributor

@shergin does this work on Fabric?

@hsourcehsource closed this Aug 21, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hsource@analysis-bot@mrousavy@sota000@facebook-github-bot@react-native-bot