feat: Enable Hermes to work on iOS by grabbou · Pull Request #29914 · react/react-native

grabbou · 2020-09-09T17:12:58Z

Summary

This PR makes it possible to build iOS applications with Hermes. Note that it doesn't work with use_frameworks! just yet.

Fixes#27845 (by downgrading iOS deployment target for RCT-Folly to 9.0)
Fixes#28810 (as above)

Checklist:

Adjust release scripts to create Hermes bytecode bundle
Release new Hermes npm package that includes iOS files (unreleased right now, if you want to try locally, you have to clone Hermes and yarn link its master to this project)
Test on a new React Native application in both Debug and Release (Device)
Test on an RNTester application in both Debug and Release (Device)
Add missing i386 to Hermes framework and enable Bitcode
Inspect CI failures for possible regressions
Resolve Folly issue as reported [0.62.0-rc.3] Catalyst macOS build issue typedef redefinition with different types #27845 and Catalyst + ReactNative: Typedef redefinition with different types ('uint8_t' (aka 'unsigned char') vs 'enum clockid_t') error when building for mac target #28810
Release new Hermes and test against it that everything works

Changelog

[IOS] [FEATURE] - Enable Hermes on iOS
[INTERNAL] - Upgrade to CocoaPods 1.10.0 to resolve Xcode 12.0 issues
[INTERNAL] - Upgrade to Xcode 12.0 on the CircleCI
[INTERNAL] - Fix building RNTester in Release mode
[INTERNAL] - Fix build-time errors of libevent with use_frameworks!
[INTERNAL] - Introduce USE_HERMES variable and test all RNTester configurations on the CI
[INTERNAL] - Do not fetch CocoaPods repository since we're using CDN anyway

Test Plan

Turn on hermes_enabled to true in your Podfile, install pods, and run the iOS application. Your app should be running Hermes now.

Preview: (note "Engine: Hermes")

alloy

This is amazing! Great stuff as always, @grabbou 👏

Thus far the changes are looking good to me, but will review again when it's no longer marked as WIP.

analysis-bot · 2020-09-09T17:45:46Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,211,837	-182,156
android	hermes	armeabi-v7a	6,861,013	-156,200
android	hermes	x86	7,646,477	-185,632
android	hermes	x86_64	7,537,421	-188,270
android	jsc	arm64-v8a	9,370,806	-165,392
android	jsc	armeabi-v7a	9,012,102	-139,124
android	jsc	x86	9,233,530	-167,344
android	jsc	x86_64	9,810,678	-171,906

Base commit: 36b0f7d

Summary: The nested `.gitattributes` file in `packages/react-native-codegen/android/` caused some confusion on Linux and macOS, causing Git to show `packages/react-native-codegen/android/gradlew.bat` as modified (CRLF removed, LF added). Instead of relying on repo-local `.gitattributes` files to convert endings in the working directory, the files should be committed to source control with the correct line endings in the first place. There is no reason to convert LF endings in .sh and many other file to CRLF on Windows (maybe this was an issue a long time ago, but unless Notepad is used this won't be a problem for practically all modern editors). Also fixed the line endings of `scripts/launchPackager.bat` which was incorrectly committed as LF. ## Changelog [Internal] [Fixed] - Line endings and .gitattributes Pull Request resolved: react#29792 Test Plan: Clone repo on Linux, macOS, and Windows, and make sure no modified files show up. Reviewed By: fkgozali Differential Revision: D23546135 Pulled By: mdvacca fbshipit-source-id: 1572fcb959212f212b137066f1aa66f0bb6e86c3

denissb · 2021-03-08T08:23:41Z

Just out of curiosity - has anyone done any benchmarks on hermes for iOS?
E.g what is the impact on bundle size and startup performance.

feat: initial commit Hermes on iOS
4c21abe

grabbou requested review from cpojer, hramos and mhorowitz as code owners September 9, 2020 17:12

grabbou commented Sep 9, 2020
View reviewed changes

Comment threadReact-Core.podspec Outdated

grabbou commented Sep 9, 2020
View reviewed changes

Comment threadpackage.json Outdated

chore: update version
1f3598d

grabbou commented Sep 9, 2020
View reviewed changes

Comment threadthird-party-podspecs/RCT-Folly.podspec

Update gradlew.bat
3aa3d95

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Sep 9, 2020

alloy reviewed Sep 9, 2020
View reviewed changes

Comment threadpackage.json Outdated

elicwhite reviewed Sep 9, 2020
View reviewed changes

Comment threadpackages/react-native-codegen/android/gradlew.bat Outdated

alloy reviewed Sep 9, 2020
View reviewed changes

This comment has been minimized.
Sign in to view

elicwhite mentioned this pull request Sep 12, 2020
v0.64.0 Discussion react-native-community/releases#207
Closed
17 tasks

This comment has been minimized.
Sign in to view

chore: release script tweaks
52bc83a

grabbou commented Sep 14, 2020
View reviewed changes

Comment threadpackages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj Outdated

grabbou commented Sep 14, 2020
View reviewed changes

Comment threadscripts/hermes-binary.sh Outdated

grabbou commented Sep 14, 2020
View reviewed changes

Comment threadscripts/react-native-xcode.sh

This comment has been minimized.
Sign in to view

friederbluemleand others added 3 commits September 15, 2020 00:18

chore: update line endings after cherry-picking fix
f7592b0

Merge branch 'master' into feat/ios-hermes-try
6921e6b

This comment has been minimized.
Sign in to view

grabbou mentioned this pull request Nov 23, 2020
Road to v0.64 Discussion react-native-community/releases#214
Closed
36 tasks

Navigation Menu

Uh oh!

feat: Enable Hermes to work on iOS - #29914

feat: Enable Hermes to work on iOS#29914
grabbou wants to merge 52 commits into
react:masterfrom
callstack:feat/ios-hermes-try

grabbou commented Sep 9, 2020•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alloy left a comment

Uh oh!

analysis-bot commented Sep 9, 2020•
edited
Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

denissb commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

grabbou commented Sep 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alloy left a comment

Choose a reason for hiding this comment

Uh oh!

analysis-bot commented Sep 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

denissb commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

grabbou commented Sep 9, 2020•
edited
Loading

analysis-bot commented Sep 9, 2020•
edited
Loading