Chore: Upgrade Detox to 16.7.2

[kelset]

Summary

With Xcode 12 being the latest, Detox 15.x has issues - in particular, it means that if you try to yarn install the dependencies for the repo, you'll be greeted by this error:

error /<stuff>/react-native/node_modules/detox: Command failed.
Exit code: 1
Command: node scripts/postinstall.js
Arguments:
Directory: /<stuff>/react-native/node_modules/detox
Output:
/<stuff>/Library/Detox/ios/5824c837515589f21c08f09b716a6eda088aa31f was found, but could not find Detox.framework inside it. This means that the Detox framework build process was interrupted.
deleting /<stuff>/Library/Detox/ios/5824c837515589f21c08f09b716a6eda088aa31f and trying to rebuild.
Extracting Detox sources...
Building Detox.framework from /<stuff>/Developer/OSS/react-native/node_modules/detox/ios_src...
child_process.js:637
throw err;
^

With the 👍 of @hramos & @alloy I've prep'd up a small defensive PR that can be quickly merged before cutting 0.64, that bumps the version of Detox from 15.4.4 to the highest version available within the reach of "no breaking changes" in changelog.

The main reason why with 16.x this error doesn't happen is that from 16.0.0:

Detox now comes as a prebuilt framework on iOS, thus lowering npm install times and saving some build issues that happen due to unexpected Xcode setups.

It would have been better to update directly to latest (at the time of writing 17.7.1) but there are at least two versions that had changelogs that seem to involve bigger changes:

• https://github.com/wix/Detox/releases/tag/17.4.7
• https://github.com/wix/Detox/releases/tag/16.8.0

Hopefully CI will will show that the bump doesn't break any test 🤞

Changelog

[Internal] [Changed] - Bumped Detox in the repo to 16.7.2 for Xcode 12 compatibility

Test Plan

Running yarn in the main repo with Node 14 & Xcode 12, without this change, will cause the error copy-pasted above. After upgrading to this version, the error disappear.

[kelset]

Looks like some CI jobs are failing, but not at the tests step.

The task failing is "Report size of RNTester.app" (which is a task after the actual testing so per se the detox bump is fine), with the error:

Missing GITHUB_PR_NUMBER. Example: 4687. PR feedback cannot be provided on GitHub without a valid pull request number.

Not sure how to fix it 😅

[alloy]

It would be great to get some input on what versions work best from people that actually use Detox (and RN), which isn’t me; do you?

[kelset]

It would be great to get some input on what versions work best from people that actually use Detox (and RN), which isn’t me; do you?

I've used Detox extensively in the first half of the year, and tbh the mindset is always to stay as close as possible to latest release because of the amount of fixes they put into each version.

That said, I think it's slightly out of scope for the purpose of this PR which is literally to just get rid of the problem I detailed above.

We could probably open a "good first issue" for folks to go over the detox testing and improve it, in the spirit of Hacktoberfest.

[alloy]

Yeah that sounds good to me 👍

[janicduplessis]

Just hit this issue trying to yarn install the repo. This shouldn't affect people actually using detox in their app since it is only the version used for our tests.

[janicduplessis]

cc @hramos

[tido64]

Looks like some CI jobs are failing, but not at the tests step.

The task failing is "Report size of RNTester.app" (which is a task after the actual testing so per se the detox bump is fine), with the error:

Missing GITHUB_PR_NUMBER. Example: 4687. PR feedback cannot be provided on GitHub without a valid pull request number.

Not sure how to fix it 😅

Can you try re-running the builds? The other PRs seems to be passing this step. Tom and I hit this issue today. Would be great to get this in.

[kelset]

@tido64 rerunning 🤞

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d8b0e9d

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,385,801	-4,096
android	hermes	armeabi-v7a	7,009,021	-8,192
android	hermes	x86	7,823,917	-8,192
android	hermes	x86_64	7,717,499	-4,096
android	jsc	arm64-v8a	9,528,006	-8,192
android	jsc	armeabi-v7a	9,147,130	-4,096
android	jsc	x86	9,392,682	-8,192
android	jsc	x86_64	9,974,392	-8,192

Base commit: d8b0e9d

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @kelset in fb14fd4.

^{When will my fix make it into a release? | Upcoming Releases}