Uh oh!
There was an error while loading. Please reload this page.
include android in npm package - #30451
Conversation
pull-bot
commented
Nov 21, 2020
dulmandakh
commented
Nov 21, 2020
it was removed in 223ac43 |
dulmandakh
commented
Nov 21, 2020
cpojer
left a comment
There was a problem hiding this comment.
Ah sorry about that, I updated the list based on the directories in the repo.
cpojer
commented
Nov 21, 2020
I can merge this at fb but we all have a week off. I recommend picking this to the release branch before it is merged to master. |
dulmandakh
commented
Nov 21, 2020
you're welcome |
alloy
commented
Nov 21, 2020
Yup, I’ll pick and push it manually, I’m not authorized to merge PRs 👍 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
commented
Nov 24, 2020
This pull request was successfully merged by @dulmandakh in 0675bee. When will my fix make it into a release? | Upcoming Releases |
Summary
RN app expects android folder with maven artifacts in NPM package, and test-manual-e2e.sh fails on 0.64-stable because it couldn't find android folder, therefore looks into remote repos and finds 0.20.1 version on bintray.
See https://github.com/facebook/react-native/blob/e99b8bbb404f8cd1f11b6c7998083be530d7b8a4/template/android/build.gradle#L27
This PR will change npm pack to include android folder with maven artifacts in NPM package, thus RN android apps can find RN in node_modules.
Changelog
[Internal] [Changed] - include android in npm package
Test Plan
With this change test-manual-e2e.sh will run successfully, previous it was failing due to duplicate classes error.