Skip to content

add file and blob globals to eslint config - #31293

Closed
shamilovtim wants to merge 2 commits into
react:mainfrom
shamilovtim:fix-add-eslint-globals
Closed

add file and blob globals to eslint config#31293
shamilovtim wants to merge 2 commits into
react:mainfrom
shamilovtim:fix-add-eslint-globals

Conversation

@shamilovtim

Copy link
Copy Markdown
Contributor

Summary

The eslint community config does not have the File and Blob polyfills in globals which have been part of the Javascript implementation for ~3 years. They were added to the Javascript API in #11573 by @satya164.

Changelog

[General] [Fixed] - Added File and Blob globals to eslint community config

Test Plan

Evidence these globals exist:

  1. Implement Blob support for XMLHttpRequest #11573
  2. Executed the following:

Screen Shot 2021-04-02 at 12 08 50 PM

Screen Shot 2021-04-02 at 12 11 56 PM

  1. Receive in console:

Screen Shot 2021-04-02 at 12 09 59 PM

Screen Shot 2021-04-02 at 12 12 27 PM

Evidence the PR works: the globals in the PR identical to the others in the eslint community config that they are in

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2021
@analysis-bot

analysis-bot commented Apr 2, 2021

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: dbe6fab
Branch: main

@shamilovtim

Copy link
Copy Markdown
ContributorAuthor

ETA?

@cortinico

Copy link
Copy Markdown
Contributor

@shamilovtim don't you mind rebasing as you're far behind in the history. Afterwards we can merge this

@shamilovtim

Copy link
Copy Markdown
ContributorAuthor

@cortinico done

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,790,526+0
androidhermesarmeabi-v7a7,179,502+0
androidhermesx868,100,411+0
androidhermesx86_648,078,241+0
androidjscarm64-v8a9,655,802+0
androidjscarmeabi-v7a8,413,668+0
androidjscx869,606,448+0
androidjscx86_6410,201,297+0

Base commit: dbe6fab
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @shamilovtim in d881c87.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Jun 17, 2022
@shamilovtim
shamilovtim deleted the fix-add-eslint-globals branch June 17, 2022 01:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@shamilovtim@analysis-bot@cortinico@facebook-github-bot@react-native-bot@satya164@sota000