Skip to content

Create rn_codegen BUCK macro - #31340

Closed
RSNara wants to merge 1 commit into
react:masterfrom
RSNara:export-D27669950
Closed

Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom
RSNara:export-D27669950

Conversation

@RSNara

@RSNaraRSNara commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Summary: Changelog: [Internal]

Differential Revision: D27669950

@facebook-github-botfacebook-github-bot added p: Facebook Partner: Facebook Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 12, 2021
@facebook-github-bot

facebook-github-bot commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27669950

@pull-bot

pull-bot commented Apr 12, 2021•
edited
Loading

Copy link
Copy Markdown
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3

@analysis-bot

analysis-bot commented Apr 12, 2021•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 0cab446

@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot

facebook-github-bot commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27669950

@analysis-bot

analysis-bot commented Apr 15, 2021

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863

Base commit: 0cab446

@facebook-github-bot

facebook-github-bot commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

This pull request has been merged in e1eb938.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Apr 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Create rn_codegen BUCK macro by RSNara · Pull Request #31340 · react/react-native · GitHub
Skip to content
Create rn_codegen BUCK macro - #31340
Closed
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Closed
Create rn_codegen BUCK macro#31340
RSNara wants to merge 1 commit into
react:masterfrom 
RSNara:export-D27669950
Conversation
@RSNara
@RSNaraRSNara
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
Summary: Changelog: [Internal]
Differential Revision: D27669950
@facebook-github-botfacebook-github-bot
added

p: Facebook
Partner: Facebook
Partner

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported

labels
Apr 12, 2021
@facebook-github-bot
facebook-github-bot
commented
Apr 12, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@pull-bot
pull-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3
@analysis-bot
analysis-bot
commented
Apr 12, 2021•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
ios-universaln/a--
Base commit: 0cab446
@RSNara@facebook-github-bot
Create rn_codegen BUCK macro (react#31340)
a2827e3
Summary:
Pull Request resolved: react#31340
Changelog: [Internal]
Differential Revision: D27669950
fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D27669950
@analysis-bot
analysis-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,852,001+29,419
androidhermesarmeabi-v7a8,373,503+15,765
androidhermesx869,308,702+29,224
androidhermesx86_649,251,542+34,869
androidjscarm64-v8a10,582,930+29,428
androidjscarmeabi-v7a10,087,528+15,763
androidjscx8610,601,126+29,218
androidjscx86_6411,184,237+34,863
Base commit: 0cab446
@facebook-github-bot
facebook-github-bot
commented
Apr 15, 2021

Copy link


Copy Markdown

Contributor
This pull request has been merged in e1eb938.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Apr 15, 2021
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@RSNara@facebook-github-bot@pull-bot@analysis-bot