Uh oh!
There was an error while loading. Please reload this page.
remove jcenter - #31609
Closed
dulmandakh wants to merge 5 commits into
Closed
Conversation
ContributorAuthor
Base commit: 78caaca |
38 tasks
facebook-github-bot
commented
Jun 1, 2021
Contributor
@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ShikaSD
commented
Jun 1, 2021
Contributor
Hey, thanks for updating this!
Do you know which dependencies are available only on Jitpack? |
dulmandakh
commented
Jun 1, 2021
ContributorAuthor
@ShikaSD i don't remember, there was a few. Most dependencies moved to MavenCentral, but i thought that having jitpack would ease migration for developers. |
dulmandakh
commented
Jun 2, 2021
ContributorAuthor
@ShikaSD removed jitpack from buck. |
analysis-bot
commented
Jun 2, 2021
Base commit: 2f477b1 |
facebook-github-bot
commented
Jun 2, 2021
Contributor
@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ShikaSD
reviewed
Jun 2, 2021
| includeModule("com.facebook.yoga", "proguard-annotations") | ||
| includeModule("com.facebook.fresco", "stetho") | ||
| } | ||
| maven { |
Contributor
There was a problem hiding this comment.
Hm, I believe we also don't need jitpack here
Only FB specific deps are remaining according to the list above, and they should be available on Maven Central
ContributorAuthor
There was a problem hiding this comment.
Yes, I can remove it but tomorrow
facebook-github-bot
commented
Jun 2, 2021
Contributor
Titozzz pushed a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
Summary: jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version. Both Gradle and Buck successfully download all the dependencies. [Android] [Changed] - Remove jcenter Pull Request resolved: react#31609 Test Plan: rn-tester builds and runs as expected. Reviewed By: mdvacca Differential Revision: D28802444 Pulled By: ShikaSD fbshipit-source-id: 043ef079d0cda77a1f8dd732678452ed712741a4
Titozzz pushed a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
Summary: jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version. Both Gradle and Buck successfully download all the dependencies. [Android] [Changed] - Remove jcenter Pull Request resolved: react#31609 Test Plan: rn-tester builds and runs as expected. Reviewed By: mdvacca Differential Revision: D28802444 Pulled By: ShikaSD fbshipit-source-id: 043ef079d0cda77a1f8dd732678452ed712741a4
tido64 pushed a commit
that referenced
this pull request
Jun 8, 2021
Summary: jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version. Both Gradle and Buck successfully download all the dependencies. ## Changelog [Android] [Changed] - Remove jcenter Pull Request resolved: #31609 Test Plan: rn-tester builds and runs as expected. Reviewed By: mdvacca Differential Revision: D28802444 Pulled By: ShikaSD fbshipit-source-id: 043ef079d0cda77a1f8dd732678452ed712741a4
Setito pushed a commit
to Setito/react-native
that referenced
this pull request
Jul 17, 2021
Summary: jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version. Both Gradle and Buck successfully download all the dependencies. ## Changelog [Android] [Changed] - Remove jcenter Pull Request resolved: react#31609 Test Plan: rn-tester builds and runs as expected. Reviewed By: mdvacca Differential Revision: D28802444 Pulled By: ShikaSD fbshipit-source-id: 043ef079d0cda77a1f8dd732678452ed712741a4
pullBot
pushed a commit
to TheRakeshPurohit/react-native
that referenced
this pull request
Oct 5, 2021
Summary: In react#31609, the deprecated `jcenter()` was replaced with `mavenCentral()`. In the template build.gradle, it _also changed the order of repos_. I am not sure if this was done intentionally or not (dulmandakh please confirm). Instead of appearing right _after_ `google()`, `mavenCentral()` was put **first** in the list, even before the local repos (that, for example, contain the `react-native` artifacts fetched by npm). Now, under normal circumstance, this _might_ not cause issues because of latency, but there is chance that Gradle could resolve incorrect versions (or at least look in the wrong repo first). The last version of `react-native` published to the public repo was [`0.20.1`](https://mvnrepository.com/artifact/com.facebook.react/react-native/0.20.1), uploaded in February 2016! This PR changes the order of `mavenCentral()` so that is consistent with both the repo's current [root level build.gradle](https://github.com/facebook/react-native/blob/main/build.gradle.kts#L34), as well as other default Android templates. Putting the local repos first will ensure they have the highest priority when looking for artifacts. `react-native` should _always_ come from the locally downloaded `node_modules/` folder, not from a remote repo. ## Changelog [Android] [Changed] - Move mavenCentral repo below local paths Pull Request resolved: react#32326 Test Plan: Create new app from template, ensure local repos appear before remote repos; `react-native` resolves to correct version. Reviewed By: yungsters Differential Revision: D31375678 Pulled By: cortinico fbshipit-source-id: e47737262b4eebb06e22a955cacd6114059bb2f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version.
Both Gradle and Buck successfully download all the dependencies.
Changelog
[Android] [Changed] - Remove jcenter
Test Plan
rn-tester builds and runs as expected.