Bump Android deps to 0.91 by mweststrate · Pull Request #31675 · react/react-native

mweststrate · 2021-06-07T09:26:36Z

Summary:
As requested in parent diff, moved the Android dep bumps into a separate diff.

Changelog

[general][changed] - [Android] Update Flipper to 0.91.1

Reviewed By: mdvacca, ShikaSD

Differential Revision: D28688486

facebook-github-bot · 2021-06-07T09:26:49Z

This pull request was exported from Phabricator. Differential Revision: D28688486

mweststrate · 2021-06-07T09:33:18Z

This is just a PR to verify public CI for above mentioned diff. Will land from phabricator if all is green.

pull-bot · 2021-06-07T09:36:44Z

	Messages
📖	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖	📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 124c1dd

analysis-bot · 2021-06-07T09:53:51Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 2a6df5b

analysis-bot · 2021-06-07T10:03:14Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,215,022	-7,331
android	hermes	armeabi-v7a	8,714,101	-30,340
android	hermes	x86	9,666,059	-19,737
android	hermes	x86_64	9,633,792	-13,788
android	jsc	arm64-v8a	10,858,880	-8,712
android	jsc	armeabi-v7a	9,749,238	-31,726
android	jsc	x86	10,905,332	-21,114
android	jsc	x86_64	11,514,582	-15,167

Base commit: e31e2cc

dulmandakh · 2021-06-07T10:25:31Z

can we just leave fresco, because it would require some extra work on Buck.

can you elaborate a little bit? This PR was green before public and internal, but I needed to rebase and in the mean time 70da640 happened. Is that something that should partially be reversed? Afaik everything seems to be green atm, except for test_docker job. Does that relate to the extra Buck work?

I would recommend to not touch other dependencies unless necessary. Here is Fresco in Buck, you need to update in here too https://github.com/facebook/react-native/blob/dc80b2dcb52fadec6a573a9dd1824393f8c29fdc/ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK

Also it would be nice to remove below lines in https://github.com/facebook/react-native/blob/master/template/android/app/build.gradle and https://github.com/facebook/react-native/blob/master/packages/rn-tester/android/app/build.gradle because it's unnecessary with the Flipper bump.
debugImplementation("com.facebook.fresco:stetho:2.3.0") exclude group:'com.facebook.fresco', module:'stetho'

test_docker failure is not related to your change. I can open a PR very soon

where did you get the hashes from in the previous update? Sorry I don't really grok the RN stack :). I merely wanted to bump the Flipper version but the rabbit hole goes a bit deeper than anticipated 😢

dulmandakh · 2021-06-07T11:45:24Z

@mweibel this patch will fix test_docker job

diff --git a/ReactAndroid/src/main/third-party/kotlin/BUCK b/ReactAndroid/src/main/third-party/kotlin/BUCK
index caad9d63e62..49d72ef5c59 100644
--- a/ReactAndroid/src/main/third-party/kotlin/BUCK+++ b/ReactAndroid/src/main/third-party/kotlin/BUCK@@ -62,7 +62,7 @@ rn_prebuilt_jar(
fb_native.remote_file(
name = "kotlin-stdlib-common.jar",
- sha1 = "6229be3465805c99db1142ad75e6c6ddeac0b04c",+ sha1 = "4fbce226ea33edfb7a42c87ae09330b07bbf1fce",
url = "mvn:org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.4.10",
)

Titozzz · 2021-06-07T12:08:04Z

@mweibel this patch will fix test_docker job

diff --git a/ReactAndroid/src/main/third-party/kotlin/BUCK b/ReactAndroid/src/main/third-party/kotlin/BUCK
index caad9d63e62..49d72ef5c59 100644
--- a/ReactAndroid/src/main/third-party/kotlin/BUCK+++ b/ReactAndroid/src/main/third-party/kotlin/BUCK@@ -62,7 +62,7 @@ rn_prebuilt_jar(
fb_native.remote_file(
name = "kotlin-stdlib-common.jar",
- sha1 = "6229be3465805c99db1142ad75e6c6ddeac0b04c",+ sha1 = "4fbce226ea33edfb7a42c87ae09330b07bbf1fce",
url = "mvn:org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.4.10",
)

I think you meant @mweststrate

facebook-github-bot · 2021-06-07T13:41:35Z

This pull request was exported from Phabricator. Differential Revision: D28688486

Summary: This PR bumps Fresco to 2.5.0, which is first version on MavenCentral since jCenter announcement. ## Changelog [Android] [Changed] - Bump Fresco to 2.5.0 Pull Request resolved: react#31699 Test Plan: CI is green Differential Revision: D29031847 Pulled By: passy fbshipit-source-id: c75753c07aa44ec8168f8d3d0f05cb43cceccbc2

Summary: Pull Request resolved: react#31675 As requested in parent diff, moved the Android dep bumps into a separate diff. ## Changelog [general][changed] - [Android] Update Flipper to 0.93.0 Reviewed By: mdvacca, ShikaSD Differential Revision: D28688486 fbshipit-source-id: 4fa35771d96c1c658191754ef8f9341ed8262b05

facebook-github-bot · 2021-06-11T09:46:44Z

This pull request was exported from Phabricator. Differential Revision: D28688486

facebook-github-bot · 2021-06-11T11:30:59Z

This pull request has been merged in 06c33e9.

Summary: Pull Request resolved: #31675 As requested in parent diff, moved the Android dep bumps into a separate diff. ## Changelog [general][changed] - [Android] Update Flipper to 0.93.0 Reviewed By: mdvacca, ShikaSD Differential Revision: D28688486 fbshipit-source-id: c3a8e0edeebdabd490b2885497e261f64bdab4bd

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 7, 2021

mweststrate marked this pull request as draft June 7, 2021 09:32

dulmandakh reviewed Jun 7, 2021
View reviewed changes

Titozzz mentioned this pull request Jun 7, 2021
Road to v0.65 Discussion react-native-community/releases#223
Closed
38 tasks

mweststrate force-pushed the export-D28688486 branch from e9a8300 to 7bbe6d0Compare June 7, 2021 13:41

kelset mentioned this pull request Jun 9, 2021
Road to v0.65.0 - RC2 phase react-native-community/releases#235
Closed
9 tasks

dulmandakhand others added 2 commits June 11, 2021 02:46

mweststrate force-pushed the export-D28688486 branch from 7bbe6d0 to 124c1ddCompare June 11, 2021 09:46

facebook-github-bot closed this in 06c33e9Jun 11, 2021

facebook-github-bot added the Merged This PR has been merged. label Jun 11, 2021

charlesbdudley mentioned this pull request Jul 29, 2021
Bump Flipper version to 0.78.0 #31100
Closed

Uh oh!

Conversation

mweststrate commented Jun 7, 2021

Changelog

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

mweststrate commented Jun 7, 2021

Uh oh!

pull-bot commented Jun 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Jun 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Jun 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulmandakhJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

mweststrateJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

dulmandakhJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

dulmandakhJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

dulmandakhJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

mweststrateJun 7, 2021

Choose a reason for hiding this comment

Uh oh!

dulmandakh commented Jun 7, 2021

Uh oh!

Titozzz commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 7, 2021

Uh oh!

facebook-github-bot commented Jun 11, 2021

Uh oh!

facebook-github-bot commented Jun 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pull-bot commented Jun 7, 2021•
edited
Loading

analysis-bot commented Jun 7, 2021•
edited
Loading

analysis-bot commented Jun 7, 2021•
edited
Loading