Skip to content

Give barTintColor and titleTextColor to the RCTNavigatorIem - #318

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

Give barTintColor and titleTextColor to the RCTNavigatorIem#318
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 27, 2015

Copy link
Copy Markdown

Resolves#273, and also another bug regarding the titleTextColor.

@facebook-github-bot

facebook-github-bot commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@AbeEstrada

AbeEstrada commented Mar 27, 2015

Copy link
Copy Markdown

👍 I hope this get merged soon.

This was referenced Mar 29, 2015
Closed
Closed
@nim23

nim23 commented Mar 29, 2015

Copy link
Copy Markdown

Just a heads up, for some reason providing the barTintColor, void's the tintColor and is always blue. I made the same changes as this commit to my local copy of react-native and as soon as I provide a barTintColor, tintColor is always blue.

@harrywincup

harrywincup commented Mar 30, 2015

Copy link
Copy Markdown

tintColor seems to be intentionally disabled if barTintColor is present, though i'm not sure why? https://github.com/facebook/react-native/blob/72d3d724a3a0c6bc46981efd0dad8f7f61121a47/React/Views/RCTWrapperViewController.m#L80

@torifat

torifat commented Mar 30, 2015

Copy link
Copy Markdown

The alpha value on barTintColor doesn't have any effect on the navigation bar. It seems using a transparent image as background is the current solution. I'm naive to iOS development. So, any expert can correct me if I'm wrong. But, I believe they have not implemented it intentionally - https://github.com/facebook/react-native/blob/master/Libraries/Components/Navigation/NavigatorIOS.ios.js#L47

@vjeux

vjeux commented Apr 3, 2015

Copy link
Copy Markdown
Contributor

There are trailing whitespaces. Also, can you make use of those in the NavigatorIOSExample?

@eduardinnieduardinni mentioned this pull request Apr 6, 2015
Closed
@eduardinni

eduardinni commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

I completed this pull request, based on all your comments here. I include one working example.

I don't know if it is possible to merge pull requests, but mine is #695

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015
sahrens pushed a commit to sahrens/react-native that referenced this pull request Apr 24, 2015
@eduardinni
NavigatorIOS custom nav bar colors
aa3d343
Summary:
NavigatorIOS with custom nav bar custom colors, working example included in
UIExplorer.
Based on pull request react#318 to complete pending work based on comments.
Closesreact#695
Github Author: Eduardo <edo.lomeli@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
@brentvatne

brentvatne commented May 30, 2015

Copy link
Copy Markdown
Collaborator

This was merged!

jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
@MoOx@czystyl
Fixup js output for9bc1d32(because of3081fac) (react#318)
07dba20
react#307 made the js generated by react#305 incorrect.
This PR fixes that.
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request May 4, 2020
@alloy
[generator-macos] Setup Podfile for platform specificity during auto-…
8cb99cd
…linking (react#318)
See react-native-community/cli#1126
@bumplzz69bumplzz69 mentioned this pull request Jun 20, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

You can't set barTintColor on NavigatoriOS

8 participants

@facebook-github-bot@AbeEstrada@nim23@harrywincup@torifat@vjeux@eduardinni@brentvatne