Android: upgrading to OkHttp from 4.9.0 to 4.9.1 to fix java.lang.NullPointerException: bio == null crash

[gedeagas]

Summary

During our routine crash report check we are occasionally seeing reports of exceptions like this in the wild from our crash stack:

java.lang.NullPointerException: bio == null
at com.android.org.conscrypt.NativeCrypto.SSL_pending_written_bytes_in_BIO(NativeCrypto.java)
at com.android.org.conscrypt.NativeSsl$BioWrapper.getPendingWrittenBytes(NativeSsl.java:660)
at com.android.org.conscrypt.ConscryptEngine.pendingOutboundEncryptedBytes(ConscryptEngine.java:566)
at com.android.org.conscrypt.ConscryptEngineSocket.drainOutgoingQueue(ConscryptEngineSocket.java:584)
at com.android.org.conscrypt.ConscryptEngineSocket.close(ConscryptEngineSocket.java:480)
at okhttp3.internal.Util.closeQuietly(Util.kt:501)
at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFile:245)
at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFile:106)
at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFile:74)
at okhttp3.internal.connection.RealCall.initExchange$okhttp(ExchangeFile:255)
at okhttp3.internal.connection.ConnectInterceptor.intercept(ExchangeFile:32)
...

This appears to only be happening on devices running Android 10 and 11. This happens because there is concurrency issue in Conscrypt where two threads race to close an SSLEngine-based SSLSocket and access to the underlying BIO is unsynchronized.

The OkHttp team already released a fix for this issue on version 4.9.1 this PR aims to update our OkHttp package to version 4.9.1.

Related discussion:
https://issuetracker.google.com/issues/177450597
https://publicobject.com/2021/01/30/bio-null/

cc @dulmandakh@fkgozali

Changelog

[Android] [Changed] - Bumping OkHttp from 4.9.0 to 4.9.1.

Test Plan

Manual & Automated from CI

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d85d72d

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,120,511	-22
android	hermes	armeabi-v7a	8,646,412	-20
android	hermes	x86	9,559,714	-30
android	hermes	x86_64	9,525,872	-22
android	jsc	arm64-v8a	10,762,957	-21
android	jsc	armeabi-v7a	9,680,118	-20
android	jsc	x86	10,797,556	-29
android	jsc	x86_64	11,405,230	-9

Base commit: d85d72d

[dulmandakh]

@ShikaSD please merge

[facebook-github-bot]

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ShikaSD merged this pull request in 6caec9d.