Skip to content

Revert "iOS: Fix refreshControl layouting (#28236)" - #32607

Closed
gaodeng wants to merge 1 commit into
react:mainfrom
gaodeng:main
Closed

Revert "iOS: Fix refreshControl layouting (#28236)"#32607
gaodeng wants to merge 1 commit into
react:mainfrom
gaodeng:main

Conversation

@gaodeng

Copy link
Copy Markdown
Contributor

This reverts commit 1b0fb9b.

Related Discussion
#28236 (comment)
#31461

Summary

Changelog

[iOS] [Fixed] - RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

Test Plan

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 16, 2021
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: a6eec50
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,477,073+0
androidhermesarmeabi-v7a7,776,596+0
androidhermesx868,945,958+0
androidhermesx86_648,890,064+0
androidjscarm64-v8a9,791,890+0
androidjscarmeabi-v7a8,752,625+0
androidjscx869,740,716+0
androidjscx86_6410,341,569+0

Base commit: a6eec50
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@philIip has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@philIipphilIip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @gaodeng, thanks for addressing this issue. can you add a before / after to the test plan? thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Platform: iOSiOS applications.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gaodeng@analysis-bot@facebook-github-bot@philIip@react-native-bot