Skip to content

Added userInterfaceStyle to Alert to override user interface style for iOS 13+ - #33553

Closed
luoxuhai wants to merge 1 commit into
react:mainfrom
luoxuhai:feature-alert-user-interface-style
Closed

Added userInterfaceStyle to Alert to override user interface style for iOS 13+#33553
luoxuhai wants to merge 1 commit into
react:mainfrom
luoxuhai:feature-alert-user-interface-style

Conversation

@luoxuhai

Copy link
Copy Markdown
Contributor

Summary

Support to override Alert interface style to match your app. For example, You want to change the style on the alert.

Changelog

[iOS] [Added] - Add userInterfaceStyle to Alert to override user interface style for iOS 13+

Test Plan

userInterfaceStyle: 'light':

userInterfaceStyle: 'dark':

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 2, 2022
@react-native-botreact-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Apr 2, 2022
@analysis-bot

analysis-bot commented Apr 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 9f1fa91
Branch: main

@analysis-bot

analysis-bot commented Apr 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,766,480-5
androidhermesarmeabi-v7a7,175,406+0
androidhermesx868,074,159+3
androidhermesx86_648,053,322-7
androidjscarm64-v8a9,643,772+47
androidjscarmeabi-v7a8,418,002+38
androidjscx869,592,950+44
androidjscx86_6410,190,136+37

Base commit: 9f1fa91
Branch: main

@ryancat

Copy link
Copy Markdown
Contributor

Thanks for working on this! I am going to import the change and hopefully get shipped soon.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ken0nek

ken0nek commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@ryancat cc: @lunaleaps

Do you think this comment is related to this pull request change?

For this change, we'll need to add a new method call for the new parameter to ensure we don't break for apps that use OTA.

#32538 (review)

Comment threadLibraries/Alert/Alert.js Outdated
@luoxuhai
luoxuhaiforce-pushed the feature-alert-user-interface-style branch from bcf26e4 to 925c53aCompareApril 5, 2022 14:06
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @luoxuhai in 47bd78f.

When will my fix make it into a release? | Upcoming Releases

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Platform: iOSiOS applications.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@luoxuhai@analysis-bot@ryancat@facebook-github-bot@ken0nek@react-native-bot