Skip to content

Fix pod install --project-directory=ios failing when Hermes is enabled - #33908

Closed
tido64 wants to merge 1 commit into
0.69-stablefrom
tido/fix-pod-install-with-dir
Closed

Fix pod install --project-directory=ios failing when Hermes is enabled#33908
tido64 wants to merge 1 commit into
0.69-stablefrom
tido/fix-pod-install-with-dir

Conversation

@tido64

@tido64tido64 commented May 25, 2022

Copy link
Copy Markdown
Collaborator

Summary

pod install --project-directory=ios silently fails to prep Hermes:

% pod install --project-directory=ios
[Codegen] Generating ios/build/generated/ios/React-Codegen.podspec.json
[Hermes] Downloading Hermes source code for commit 515e112edc267ad58d3c70991b3d9a721cc66b19
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 9478k 0 9478k 0 0 3939k 0 --:--:-- 0:00:02 --:--:-- 5591k
[Hermes] Expanding Hermes tarball for commit 515e112edc267ad58d3c70991b3d9a721cc66b19
[Hermes] Using pre-built HermesC
[!] One or more resources were not found and will not be included in the project. If they are found later and you want to include them, run `pod install` again.
warn Multiple Podfiles were found: ios/Podfile,macos/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md
Auto-linking React Native module for target `ReactTestApp`: ReactTestApp-DevSupport
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] No podspec found for `hermes-engine` in `../node_modules/react-native/sdks/hermes/hermes-engine.podspec`
% ls -l node_modules/react-native/sdks
total 0
hermes-engine
hermesc

Changelog

[iOS] [Fixed] - pod install --project-directory=ios fails when Hermes is enabled

Test Plan

Instead of running pod install inside ios folder, run pod install --project-directory=ios.

@tido64
tido64 requested review from cortinico, hramos and kelsetMay 25, 2022 12:15
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 25, 2022
@tido64

Copy link
Copy Markdown
CollaboratorAuthor

Fix for main: #33909

@hramoshramos self-assigned this May 25, 2022
@hramos

Copy link
Copy Markdown
Contributor

I have approved and imported #33909 and I will request these changes to be cherry-picked onto 0.69 once they land on main.

@hramoshramos closed this May 26, 2022
@tido64
tido64 deleted the tido/fix-pod-install-with-dir branch May 26, 2022 20:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: MicrosoftPartner: MicrosoftPartnerPlatform: iOSiOS applications.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tido64@hramos@facebook-github-bot@react-native-bot