Skip to content

Build RN Tester with CMake - #33937

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D36760309
Closed

Build RN Tester with CMake#33937
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D36760309

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
This moves the build of RNTester from Unix Make to CMake
This will serve as a blueprint for users that are looking into using CMake end-to-end in their buildls.

In order to make this possible I had to:

  • Add an Android-prebuilt.cmake file that works similar to the Android-prebuilt.mk for feeding prebuilt .so files to the consumer build.
  • Update the codegen to use JSI_EXPORT on several objects/classes as CMake has stricter visibility rules than Make
  • Update the sample native module in nativemodule/samples/platform/android/ to use CMake instead of Make

Changelog:
[Internal] [Changed] - Build RN Tester with CMake

Differential Revision: D36760309

Summary:
This moves the build of RNTester from Unix Make to CMake
This will serve as a blueprint for users that are looking into using CMake end-to-end in their buildls.
In order to make this possible I had to:
* Add an `Android-prebuilt.cmake` file that works similar to the `Android-prebuilt.mk` for feeding prebuilt .so files to the consumer build.
* Update the codegen to use `JSI_EXPORT` on several objects/classes as CMake has stricter visibility rules than Make
* Update the sample native module in `nativemodule/samples/platform/android/` to use CMake instead of Make
Changelog:
[Internal] [Changed] - Build RN Tester with CMake
Differential Revision: D36760309
fbshipit-source-id: b313f738ab5a8f8afb7319c3ccab559c40a28097
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 31, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D36760309

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: f4123b0
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,778,777-9,467
androidhermesarmeabi-v7a7,168,238-23,587
androidhermesx868,089,142-10,456
androidhermesx86_648,065,325-11,778
androidjscarm64-v8a9,646,839-9,466
androidjscarmeabi-v7a8,405,211-23,598
androidjscx869,598,017-10,461
androidjscx86_6410,191,253-11,774

Base commit: f4123b0
Branch: main

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in f1c614b.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Jun 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cortinico@facebook-github-bot@analysis-bot@react-native-bot