Use GCC_PREPROCESSOR_DEFINITIONS to set FB_SONARKIT_ENABLED

[janicduplessis]

Summary

OTHER_CFLAGS doesn't seem to work when the file is imported from Objc++. This causes flipper to not be included.

Changelog

[iOS] [Fixed] - Use GCC_PREPROCESSOR_DEFINITIONS to set FB_SONARKIT_ENABLED

Test Plan

Tested the change in an app. Used a breakpoint to see that flipper code is not executed before this change, and is after. Also made sure other GCC_PREPROCESSOR_DEFINITIONS set by cocoapods are still properly inherited.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,782,262	+0
android	hermes	armeabi-v7a	7,172,079	+0
android	hermes	x86	8,092,955	+0
android	hermes	x86_64	8,068,944	+0
android	jsc	arm64-v8a	9,649,085	+0
android	jsc	armeabi-v7a	8,407,885	+0
android	jsc	x86	9,600,644	+0
android	jsc	x86_64	10,193,678	+0

Base commit: 43f831b
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 43f831b
Branch: main

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @janicduplessis in 77e6bff.

^{When will my fix make it into a release? | Upcoming Releases}