Uh oh!
There was an error while loading. Please reload this page.
[yoga] revert #33381 changes - #33973
Closed
Kudo wants to merge 2 commits into
Closed
Conversation
Base commit: edb27e3 |
Kudo
marked this pull request as ready for review
June 7, 2022 23:27
Base commit: edb27e3 |
Uh oh!
There was an error while loading. Please reload this page.
facebook-github-bot
commented
Jun 8, 2022
Contributor
@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot pushed a commit
that referenced
this pull request
Jun 10, 2022
Summary: Changelog: [Internal][Fixed] - #33973 breaks the internal CI, as it depends on the outdated offline mirror for `Pods/Target Support Files`. Reviewed By: cortinico Differential Revision: D37038213 fbshipit-source-id: 1d27c9c32f2c3ddecd15a83935c520d1e1524b21
react-native-bot
commented
Jun 10, 2022
Collaborator
This pull request was successfully merged by @Kudo in c2088e1. When will my fix make it into a release? | Upcoming Releases |
fortmarek pushed a commit
that referenced
this pull request
Jun 29, 2022
Summary: react/yoga#1150 is better than the tricky #33381 and fix the build error on react-native 0.69 with swift clang module. as react/yoga#1150 is landed as 43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change. ## Changelog [iOS] [Changed] - Better fix for yoga + swift clang module build error Pull Request resolved: #33973 Test Plan: ci passed Reviewed By: cortinico, cipolleschi Differential Revision: D36998007 Pulled By: dmitryrykun fbshipit-source-id: fa11bd950e2a1be6396f286086f4e7941ad2ff5b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react/yoga#1150 is better than the tricky #33381 and fix the build error on react-native 0.69 with swift clang module. as react/yoga#1150 is landed as 43f831b, i'm reverting the previous change, only leaving the necessary react_native_pods.rb change.
Changelog
[iOS] [Changed] - Better fix for yoga + swift clang module build error
Test Plan
ci passed