Skip to content

Move cocoapods utilities to utils.rb - Part 1 - #33978

Closed
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D37004347
Closed

Move cocoapods utilities to utils.rb - Part 1#33978
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D37004347

Conversation

@cipolleschi

@cipolleschicipolleschi commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Summary:
This Diff moves part of the utilities from the react_native_pods file to a specific utils.rb file.

It adds tests for these utils and improve our test mocks.

The goal is to simplify the react_native_pods.rb so it's easier to work with it.

I decided to split this diff in 2 because it was becoming quite big.

Differential Revision: D37004347

Changelog

[iOS][Changed] - Refactoring part of the react_native_pods.rb script

@cipolleschi
cipolleschi requested a review from hramos as a code ownerJune 8, 2022 14:33
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 8, 2022
@pull-bot

pull-bot commented Jun 8, 2022

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 0599639

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D37004347

@react-native-botreact-native-bot added the Platform: iOS iOS applications. label Jun 8, 2022
@analysis-bot

analysis-bot commented Jun 8, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,782,640+0
androidhermesarmeabi-v7a7,172,350+0
androidhermesx868,093,283+0
androidhermesx86_648,069,317+0
androidjscarm64-v8a9,649,489+0
androidjscarmeabi-v7a8,408,181+0
androidjscx869,600,998+0
androidjscx86_6410,194,061+0

Base commit: a0e6ffe
Branch: main

@analysis-bot

analysis-bot commented Jun 8, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: a0e6ffe
Branch: main

Summary:
Pull Request resolved: #33978
This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file.
It adds tests for these utils and improve our test mocks.
The goal is to simplify the `react_native_pods.rb` so it's easier to work with it.
I decided to split this diff in 2 because it was becoming quite big.
## Changelog
[iOS][Changed] - Refactoring part of the react_native_pods.rb script
Reviewed By: cortinico
Differential Revision: D37004347
fbshipit-source-id: 0cb55d2555168b203d520265545851325ec8bbcd
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D37004347

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 7a27044.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Jun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartnerPlatform: iOSiOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cipolleschi@pull-bot@facebook-github-bot@analysis-bot@react-native-bot