Uh oh!
There was an error while loading. Please reload this page.
Destructure use_react_native! parameters and doc - #34177
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
added 2 commits
July 12, 2022 08:16
Summary: It extracts the code related to the codegen from the main `react_native_pods` script to a dedicated file, adding also tests. Differential Revision: https://www.internalfb.com/diff/D37755818?entry_point=27 fbshipit-source-id: c78752f8ac24760fbaaf12133f9916652900b007
Summary: This Diff destructures the parameters of the use_react_native! function. It does that in a backward compatible way, so we there should be no disruptions. It also adds documentation to the various public method we want to export to our users. ## Changelog [iOS][Changed] - Destruct use_reactnative parameters and ad ddocumentation Differential Revision: D37787365 fbshipit-source-id: 328c1e3eae6877b02c960fe82d7680d0ba94a251
facebook-github-bot
commented
Jul 12, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D37787365 |
analysis-bot
commented
Jul 12, 2022
Base commit: ff785db |
analysis-bot
commented
Jul 12, 2022
Base commit: ff785db |
react-native-bot
commented
Jul 19, 2022
Collaborator
This pull request was successfully merged by @cipolleschi in 79a37e5. When will my fix make it into a release? | Upcoming Releases |
kelset pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: Pull Request resolved: #34177 This Diff destructures the parameters of the use_react_native! function. It does that in a backward compatible way, so we there should be no disruptions. It also adds documentation to the various public method we want to export to our users. ## Changelog [iOS][Changed] - Destruct use_reactnative parameters and ad ddocumentation Reviewed By: cortinico Differential Revision: D37787365 fbshipit-source-id: 27f9030db2e8c6c66b9548b4c1287eb8165ae5fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff destructures the parameters of the use_react_native! function. It does that in a backward compatible way, so we there should be no disruptions.
It also adds documentation to the various public method we want to export to our users.
Changelog
[iOS][Changed] - Destruct use_reactnative parameters and ad ddocumentation
Differential Revision: D37787365