Uh oh!
There was an error while loading. Please reload this page.
[fix] Hermes pod: change logic to use the hermes tag to set the pod source correctly - #34221
Closed
kelset wants to merge 4 commits into
Closed
[fix] Hermes pod: change logic to use the hermes tag to set the pod source correctly#34221kelset wants to merge 4 commits into
kelset wants to merge 4 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
cipolleschi
approved these changes
Jul 19, 2022
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me! Thanks for this PR
facebook-github-bot
commented
Jul 19, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jul 19, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Jul 19, 2022
Base commit: 1d997ce |
kelset added a commit
that referenced
this pull request
Jul 19, 2022
…correctly (#34221) Summary: This fix is necessarly to ensure that when working on the codebase in the `0.XX-stable` branches (ex. when you are working on a release) the Hermes podfile is correctly set against the right commit for that branch, and not latest commit from main branch of Hermes repo. I didn't add a check to verify that the file `.hermesversion` exists because I think it's safe to assume that the file and the tag correctly exists when this step (doing a pod install on the `0.XX-stable` branch). Once this is merged, we need to cherry pick it on both the 0.69 and 0.70 branches ## Changelog [iOS] [Fixed] - Hermes pod: change logic to use the hermes tag to set the pod source correctly Pull Request resolved: #34221 Test Plan: * git clone the repo * checkout 0.69-stable branch * follow https://reactnative.dev/contributing/release-testing * without this commit, when testing RNTester + iOS + Hermes the app will insta-crash on opening * with it, the app gets build successfully Reviewed By: cortinico Differential Revision: D37957660 Pulled By: cipolleschi fbshipit-source-id: 4e50099ed712b1ad8e6439822e3f530142982c1b
kelset added a commit
that referenced
this pull request
Jul 19, 2022
…correctly (#34221) Summary: This fix is necessarly to ensure that when working on the codebase in the `0.XX-stable` branches (ex. when you are working on a release) the Hermes podfile is correctly set against the right commit for that branch, and not latest commit from main branch of Hermes repo. I didn't add a check to verify that the file `.hermesversion` exists because I think it's safe to assume that the file and the tag correctly exists when this step (doing a pod install on the `0.XX-stable` branch). Once this is merged, we need to cherry pick it on both the 0.69 and 0.70 branches ## Changelog [iOS] [Fixed] - Hermes pod: change logic to use the hermes tag to set the pod source correctly Pull Request resolved: #34221 Test Plan: * git clone the repo * checkout 0.69-stable branch * follow https://reactnative.dev/contributing/release-testing * without this commit, when testing RNTester + iOS + Hermes the app will insta-crash on opening * with it, the app gets build successfully Reviewed By: cortinico Differential Revision: D37957660 Pulled By: cipolleschi fbshipit-source-id: 4e50099ed712b1ad8e6439822e3f530142982c1b
react-native-bot
commented
Jul 19, 2022
Collaborator
This pull request was successfully merged by @kelset in 46a9edc. When will my fix make it into a release? | Upcoming Releases |
mikehardy
commented
Jul 19, 2022
Contributor
This likely explains some strange results I experienced when trying to look at use_frameworks/hermes build by exposing the runtime version / jsiExecutorDescription global vars! Nice find |
analysis-bot
commented
Jul 19, 2022
Base commit: 46a9edc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix is necessarly to ensure that when working on the codebase in the
0.XX-stablebranches (ex. when you are working on a release) the Hermes podfile is correctly set against the right commit for that branch, and not latest commit from main branch of Hermes repo.I didn't add a check to verify that the file
.hermesversionexists because I think it's safe to assume that the file and the tag correctly exists when this step (doing a pod install on the0.XX-stablebranch).Once this is merged, we need to cherry pick it on both the 0.69 and 0.70 branches
Changelog
[iOS] [Fixed] - Hermes pod: change logic to use the hermes tag to set the pod source correctly
Test Plan