') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [FIX] Build hermes from source on PR against stable by cipolleschi · Pull Request #34228 · react/react-native · GitHub
Skip to content

[FIX] Build hermes from source on PR against stable - #34228

Merged
cipolleschi merged 1 commit into
0.69-stablefrom
fix/build_hermes_against_stable
Jul 20, 2022
Merged

[FIX] Build hermes from source on PR against stable#34228
cipolleschi merged 1 commit into
0.69-stablefrom
fix/build_hermes_against_stable

Conversation

@cipolleschi

@cipolleschicipolleschi commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Summary

This PR ensures that we can build Hermes from source also when we are creating prs against stable branches.
It also revert the changes of #34223 because they did not fix the issue.

Changelog

[General] [Changed] - Make sure we can build Hermes from source when PR are opened agains -stable

Test Plan

Tested locally + CircleCI is green (a part from test_ios_unit)

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 20, 2022
@cipolleschi
cipolleschiforce-pushed the fix/build_hermes_against_stable branch from 55ed302 to a2d6f5aCompareJuly 20, 2022 11:49
@cipolleschi
cipolleschi marked this pull request as ready for review July 20, 2022 11:51
@cipolleschi
cipolleschi requested a review from hramos as a code ownerJuly 20, 2022 11:51
@cipolleschicipolleschi mentioned this pull request Jul 20, 2022
Merged
@analysis-bot

analysis-bot commented Jul 20, 2022•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,794,949-25,814
androidhermesarmeabi-v7a7,196,376-18,255
androidhermesx868,103,481-30,982
androidhermesx86_648,083,326-29,249
androidjscarm64-v8a9,667,984-30,153
androidjscarmeabi-v7a8,438,444-15,825
androidjscx869,616,904-33,040
androidjscx86_6410,214,293-33,864

Base commit: 143a0f7
Branch: main

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 20, 2022
facebook-github-bot pushed a commit that referenced this pull request Jul 20, 2022
Riccardo Cipolleschi@facebook-github-bot
Build Hermes in CI also when it is against stable branch (#34224)
361d939
Summary:
Pull Request resolved: #34224
This Diff is a copy of this [PR](#34228) that we have against 0.69-stable.
This Diff makes sure we can build Hermes also in PR that are created against a stable branch
## Changelog
[General] [Changed] - Make sure we can build Hermes from source when PR are opened agains -stable
Reviewed By: cortinico
Differential Revision: D37961092
fbshipit-source-id: 65577fcc69f0e2a68377cbd46e3bd3a6af24e7c3
@cipolleschi
cipolleschi merged commit 30d1e20 into 0.69-stableJul 20, 2022
@cipolleschi
cipolleschi deleted the fix/build_hermes_against_stable branch July 20, 2022 15:56
@cipolleschi
cipolleschi restored the fix/build_hermes_against_stable branch July 21, 2022 07:47
@cipolleschi
cipolleschi deleted the fix/build_hermes_against_stable branch July 21, 2022 07:51
@cipolleschi
cipolleschi restored the fix/build_hermes_against_stable branch July 22, 2022 08:19
@yungsters
yungsters deleted the fix/build_hermes_against_stable branch August 12, 2022 17:30
@snyk-botsnyk-bot mentioned this pull request Aug 16, 2022
Open
@NOUIYNOUIY mentioned this pull request Aug 30, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 16, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramoshramosAwaiting requested review from hramos

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cipolleschi@analysis-bot@facebook-github-bot