Skip to content

Fix test-manual-e2e on Android/Hermes for New App Template#34294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
Closed

Fix test-manual-e2e on Android/Hermes for New App Template #34294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/test-manual-e2e.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,6 @@ selected_vm=""
PACKAGE_VERSION=""

test_android(){
generate_maven_artifacts
if [ "$1" == "1" ]; then
test_android_hermes
elif [ "$1" == "2" ]; then
Expand All@@ -43,7 +42,9 @@ test_android(){

generate_maven_artifacts(){
rm -rf android
./gradlew :ReactAndroid:installArchives || error "Couldn't generate artifacts"

./gradlew :ReactAndroid:installArchives || error "Couldn't generate React Native Maven artifacts"
./gradlew :ReactAndroid:hermes-engine:installArchives || error "Couldn't generate Hermes Engine Maven artifacts"

success "Generated artifacts for Maven"
}
Expand DownExpand Up@@ -109,6 +110,10 @@ kill_packagers(){
init_template_app(){
kill_packagers

if [ "$selected_platform" == "1" ]; then
generate_maven_artifacts
fi

PACKAGE_VERSION=$(cat package.json \
| grep version \
| head -1 \
Expand Down