Skip to content

accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic#34371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabOnReact wants to merge 3 commits into from
Closed

accessibilityLabelledBy use DynamicFromObject to parse String to Dynamic #34371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab812ef
String can not be cast to object
fabOnReact Aug 9, 2022
e181990
Code Review from Alex
fabOnReact Aug 15, 2022
efa18e0
Merge branch 'main' into accessibility-labeled-by
fabOnReact Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ColorPropConverter;
import com.facebook.react.bridge.Dynamic;
import com.facebook.react.bridge.DynamicFromObject;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.yoga.YogaConstants;
Expand DownExpand Up@@ -92,7 +93,8 @@ public void setProperty(T view, String propName, @Nullable Object value) {
mViewManager.setNativeId(view, (String) value);
break;
case ViewProps.ACCESSIBILITY_LABELLED_BY:
mViewManager.setAccessibilityLabelledBy(view, (Dynamic) value);
Dynamic dynamicFromObject = new DynamicFromObject(value);
mViewManager.setAccessibilityLabelledBy(view, dynamicFromObject);
break;
case ViewProps.OPACITY:
mViewManager.setOpacity(view, value == null ? 1.0f : ((Double) value).floatValue());
Expand Down
11 changes: 11 additions & 0 deletions packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ const {
StyleSheet,
Slider,
Platform,
Switch,
} = require('react-native');
import type {EventSubscription} from 'react-native/Libraries/vendor/emitter/EventEmitter';

Expand DownExpand Up@@ -212,6 +213,16 @@ class AccessibilityExample extends React.Component<{}> {
/>
</View>
</RNTesterBlock>
<RNTesterBlock title="Switch with accessibilityLabelledBy attribute">
<View>
<Text nativeID="formLabel4">Enable Notifications</Text>
<Switch
value={true}
accessibilityLabel="switch test1"
accessibilityLabelledBy="formLabel4"
/>
</View>
</RNTesterBlock>
</View>
);
}
Expand Down