Uh oh!
There was an error while loading. Please reload this page.
Fix test_buck by providing exported deps for textinput target - #34436
Closed
cortinico wants to merge 1 commit into
Closed
Fix test_buck by providing exported deps for textinput target#34436cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
cortinico
marked this pull request as ready for review
August 17, 2022 11:44
facebook-github-bot
commented
Aug 17, 2022
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
analysis-bot
commented
Aug 17, 2022
Base commit: 1bd2760 |
react-native-bot
commented
Aug 17, 2022
Collaborator
This pull request was successfully merged by @cortinico in 30e54ad. When will my fix make it into a release? | Upcoming Releases |
roryabraham pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…34436) Summary: This is an attempt to fix the broken `test_buck` as the `/textinput` target now needs to access the Kotlin stdlib dependencies ## Changelog [Internal] - Fix test_buck by providing exported deps for textinput target Pull Request resolved: react#34436 Test Plan: Will wait for a CircleCI result Reviewed By: cipolleschi Differential Revision: D38782473 Pulled By: cortinico fbshipit-source-id: 72265c34092372189d75df732b64a1e370453472
kelset pushed a commit
that referenced
this pull request
Apr 17, 2023
Summary: This is an attempt to fix the broken `test_buck` as the `/textinput` target now needs to access the Kotlin stdlib dependencies ## Changelog [Internal] - Fix test_buck by providing exported deps for textinput target Pull Request resolved: #34436 Test Plan: Will wait for a CircleCI result Reviewed By: cipolleschi Differential Revision: D38782473 Pulled By: cortinico fbshipit-source-id: 72265c34092372189d75df732b64a1e370453472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix the broken
test_buckas the/textinputtarget now needs to access the Kotlin stdlib dependenciesChangelog
[Internal] - Fix test_buck by providing exported deps for textinput target
Test Plan
Will wait for a CircleCI result