Skip to content

feat: Add tabIndex prop to View component - #34486

Closed
gabrieldonadel wants to merge 2 commits into
react:mainfrom
gabrieldonadel:feat/add-tab-index-to-view
Closed

feat: Add tabIndex prop to View component#34486
gabrieldonadel wants to merge 2 commits into
react:mainfrom
gabrieldonadel:feat/add-tab-index-to-view

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Summary

This adds the tabIndex Android only prop to View as requested on #34424 mapping the existing focusable prop to tabIndex so that tabIndex={0} maps to focusable={true} and tabIndex={-1} represents focusable={false}.

Changelog

[Android] [Added] - Add tabIndex prop to View component

Test Plan

I'm still investigating the best way to test this but we're are just mapping this to an existing prop

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 23, 2022
@react-native-botreact-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Aug 23, 2022
@gabrieldonadel
gabrieldonadelforce-pushed the feat/add-tab-index-to-view branch 2 times, most recently from 0f35a0d to 7fea932CompareAugust 23, 2022 19:23
@analysis-bot

analysis-bot commented Aug 23, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,617,967+95
androidhermesarmeabi-v7a7,032,206+87
androidhermesx867,918,045+114
androidhermesx86_647,891,666+118
androidjscarm64-v8a9,495,266-17
androidjscarmeabi-v7a8,272,879-35
androidjscx869,433,068-6
androidjscx86_6410,026,062-2

Base commit: ed21a3e
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel
gabrieldonadelforce-pushed the feat/add-tab-index-to-view branch from 7fea932 to 4b11bd8CompareAugust 24, 2022 17:59
@gabrieldonadel

Copy link
Copy Markdown
CollaboratorAuthor

@necolas I've just rebased it now that CI has been fixed

@analysis-bot

analysis-bot commented Aug 24, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: ed21a3e
Branch: main

Comment threadLibraries/Components/View/ViewPropTypes.js Outdated
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel
gabrieldonadelforce-pushed the feat/add-tab-index-to-view branch from dc7a62b to 3d2d515CompareAugust 28, 2022 14:45
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gabrieldonadel in 621f4cf.

When will my fix make it into a release? | Upcoming Releases

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Platform: AndroidAndroid applications.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrieldonadel@analysis-bot@facebook-github-bot@react-native-bot@necolas