Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for Modal on iOS when Fabric is enabled - #34487
Closed
gabrieldonadel wants to merge 1 commit into
Closed
feat: Add support for Modal on iOS when Fabric is enabled#34487gabrieldonadel wants to merge 1 commit into
gabrieldonadel wants to merge 1 commit into
Conversation
gabrieldonadelforce-pushed
the
feat/add-modal-host-view
branch
from
August 24, 2022 00:45
0e4f41e to
5839c56Compare
Base commit: f3def13 |
facebook-github-bot
commented
Aug 24, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Aug 24, 2022
Contributor
Hi @gabrieldonadel, thank you so much for this PR. Could you please rbase onto |
gabrieldonadelforce-pushed
the
feat/add-modal-host-view
branch
from
August 24, 2022 16:19
5839c56 to
4c0a1ecComparegabrieldonadel
commented
Aug 24, 2022
CollaboratorAuthor
Sure @cipolleschi, I've just rebased it |
analysis-bot
commented
Aug 24, 2022
Base commit: f3def13 |
facebook-github-bot
commented
Aug 25, 2022
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Aug 26, 2022
Collaborator
This pull request was successfully merged by @gabrieldonadel in 9ac437f. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on a fix for #29974 (I have a draft for that already (gabrieldonadel#16), just waiting for #34406 to get merged) I noticed that the
KeyboardAvoidingViewtests on RNTester on iOS were not working with Fabric enabled because theModalHostViewcomponent was still not implemented. Upon some more investigation, I found this code suggestion from Milker90 (#33652 (comment)) that enables the Modal component on iOS when Fabric is enabled.Closes#33652
Changelog
[iOS] [Added] - Add support for Modal on iOS when Fabric is enabled
Test Plan
Modalcomponent through the sections changing propsScreen.Recording.2022-08-23.at.21.29.51.mov