Uh oh!
There was an error while loading. Please reload this page.
feat: Add rows prop to TextInput component - #34488
Conversation
Base commit: f3def13 |
facebook-github-bot
commented
Aug 24, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Aug 24, 2022
Hi @gabrieldonadel, thanks for the PR. Could you please rebase this onto |
3d4c49f to
d757a89Comparegabrieldonadel
commented
Aug 24, 2022
Sure @cipolleschi, I've just rebased it |
analysis-bot
commented
Aug 24, 2022
Base commit: f3def13 |
necolas
commented
Aug 24, 2022
Is there an equivalent to |
gabrieldonadel
commented
Aug 24, 2022
Unfortunately no @necolas, but I guess we could implement it using |
necolas
commented
Aug 24, 2022
Yeah we can look into unifying text input behavior in another PR. Thanks! |
facebook-github-bot
commented
Aug 25, 2022
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Aug 25, 2022
This pull request was successfully merged by @gabrieldonadel in 49c9ccd. When will my fix make it into a release? | Upcoming Releases |
gabrieldonadel
commented
Aug 25, 2022
@lunaleaps@necolas quick question about these new TextInput props, should we deprecate these old props that are being mapped e.g. #34444 (comment)? Should I open a PR for |
lunaleaps
commented
Aug 30, 2022
Let's hold off on this. There's concern that people don't have time to actively migrate their callsites and will get noise. Sorry about the trouble! |
Summary
This adds the Android only
rowsprop to TextInput as requested on #34424 mapping the existingnumberOfLinesprop torows. This PR also updates the TextInputExample.android on the RNTester in order to facilitate the manual QA of this.Changelog
[Android] [Added] - Add rows prop to TextInput component
Test Plan
TextInputcomponent through theFixed number of linessectionScreen.Recording.2022-08-23.at.22.52.05.mov