feat: added aria-modal as alias for accessibilityViewIsModal(iOS) by dakshbhardwaj · Pull Request #34506 · react/react-native

dakshbhardwaj · 2022-08-26T08:18:21Z

Summary

This adds the aria-modal prop to the components where it's used as requested on #34424, mapping web aria-modal to equivalent accessibilityViewIsModal

Changelog

[General] [Added] - Add aria-modal prop to basic component

TestPlan

Checked manually we are receiving the values by props.

github-actions · 2022-08-26T08:19:16Z

	Warnings
⚠️	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against ad116e0

analysis-bot · 2022-08-26T08:43:58Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,641,629	+467
android	hermes	armeabi-v7a	7,053,984	+461
android	hermes	x86	7,943,406	+475
android	hermes	x86_64	7,915,311	+462
android	jsc	arm64-v8a	9,514,777	+390
android	jsc	armeabi-v7a	8,290,381	+382
android	jsc	x86	9,454,094	+379
android	jsc	x86_64	10,045,174	+390

Base commit: 82e9c6a
Branch: main

cipolleschi · 2022-08-26T13:19:18Z

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

…view-is-modal

dakshbhardwaj · 2022-08-26T13:23:34Z

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

@cipolleschi I have rebased it with main

analysis-bot · 2022-08-26T13:44:42Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: e8739e9
Branch: main

facebook-github-bot · 2022-08-26T16:59:39Z

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-08-26T18:05:50Z

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…sibility-view-is-modal

facebook-github-bot · 2022-09-05T09:56:56Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…sibility-view-is-modal

facebook-github-bot · 2022-09-07T12:28:05Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…view-is-modal

facebook-github-bot · 2022-09-08T08:43:50Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…view-is-modal

…sibility-view-is-modal

…view-is-modal

jacdebug · 2022-09-09T11:09:43Z

+ restProps['aria-modal'] !== null
+ ? restProps['aria-modal']
+ : restProps.accessibilityViewIsModal,


Suggested change
restProps['aria-modal']!==null
? restProps['aria-modal']
: restProps.accessibilityViewIsModal,
restProps['aria-modal']??restProps.accessibilityViewIsModal,

jacdebug · 2022-09-09T11:10:12Z

+ this.props['aria-modal'] !== null
+ ? this.props['aria-modal']
+ : this.props.accessibilityViewIsModal


Suggested change
this.props['aria-modal']!==null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal']??this.props.accessibilityViewIsModal

jacdebug · 2022-09-09T11:10:32Z

+ this.props['aria-modal'] !== null
+ ? this.props['aria-modal']
+ : this.props.accessibilityViewIsModal


Suggested change
this.props['aria-modal']!==null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal']??this.props.accessibilityViewIsModal

jacdebug · 2022-09-09T11:10:45Z

+ this.props['aria-modal'] !== null
+ ? this.props['aria-modal']
+ : this.props.accessibilityViewIsModal,


Suggested change
this.props['aria-modal']!==null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal,
this.props['aria-modal']??this.props.accessibilityViewIsModal,

jacdebug · 2022-09-09T11:10:59Z

+ this.props['aria-modal'] !== null
+ ? this.props['aria-modal']
+ : this.props.accessibilityViewIsModal


Suggested change
this.props['aria-modal']!==null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal']??this.props.accessibilityViewIsModal

dakshbhardwaj · 2022-09-09T12:42:12Z

@jacdebug i have pushed the changes

facebook-github-bot · 2022-09-12T07:44:12Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-09-12T12:05:05Z

This pull request was successfully merged by @dakshbhardwaj in 095f19a.

^{When will my fix make it into a release? | Upcoming Releases}

feat: added ariaModal as alias for accessibilityViewIsModal
91a4124

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 26, 2022

react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 26, 2022

improved the documentation
04cf3c9

Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
d708cfe
…view-is-modal

necolas mentioned this pull request Aug 26, 2022
[w3c] ☂️ Web Props (Part 1) umbrella issue #34424
Closed
70 tasks

necolas reviewed Aug 26, 2022
View reviewed changes

Comment threadLibraries/Components/Pressable/Pressable.js Outdated

added a check for aria-model
75e405c

Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
ce50c93
…sibility-view-is-modal

Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
1255ab8
…sibility-view-is-modal

Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
1e52fe6
…view-is-modal

Daksh Bhardwaj added 3 commits September 8, 2022 17:24

Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
97fbf1c
…view-is-modal

Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
6f5e29b
…sibility-view-is-modal

Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
13b5e10
…view-is-modal

jacdebug requested changes Sep 9, 2022
View reviewed changes

review changes
ad116e0

jacdebug approved these changes Sep 9, 2022
View reviewed changes

facebook-github-bot closed this in 095f19aSep 12, 2022

react-native-bot added the Merged This PR has been merged. label Sep 12, 2022

Uh oh!

Conversation

dakshbhardwaj commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

TestPlan

Uh oh!

github-actionsBot commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipolleschi commented Aug 26, 2022

Uh oh!

dakshbhardwaj commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Aug 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 26, 2022

Uh oh!

Uh oh!

facebook-github-bot commented Aug 26, 2022

Uh oh!

facebook-github-bot commented Sep 5, 2022

Uh oh!

facebook-github-bot commented Sep 7, 2022

Uh oh!

facebook-github-bot commented Sep 8, 2022

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

jacdebugSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

dakshbhardwaj commented Sep 9, 2022

Uh oh!

facebook-github-bot commented Sep 12, 2022

Uh oh!

react-native-bot commented Sep 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dakshbhardwaj commented Aug 26, 2022•
edited
Loading

github-actionsBot commented Aug 26, 2022•
edited
Loading

analysis-bot commented Aug 26, 2022•
edited
Loading

dakshbhardwaj commented Aug 26, 2022•
edited
Loading

analysis-bot commented Aug 26, 2022•
edited
Loading